Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable regex tests when repl feature not enabled #90

Merged
merged 1 commit into from
May 17, 2022

Conversation

notmandatory
Copy link
Member

Description

I noticed that when I disable default features and don't enable the repl feature that the regex tests fail because they need the regex dependency that the repl feature brings in. This PR is to simply disable the regex related test code if the repl feature isn't enabled.

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory self-assigned this May 11, 2022
@notmandatory notmandatory added this to the Release 0.6.0 milestone May 11, 2022
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 953c097

Repro'd the bug using

cargo test --features=cli,key-value-db --no-default-features

@notmandatory notmandatory merged commit 51b2b6a into bitcoindevkit:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants