Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miniscript version to 6.1.0 #86

Merged
merged 1 commit into from
May 6, 2022

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Apr 28, 2022

Description

Did a cargo update to update miniscript dependency in Cargo.lock to 6.1.0 and fix related audit issue.

Crate:         miniscript
Version:       6.0.1
Warning:       yanked
Dependency tree: 
miniscript 6.0.1
└── bdk 0.17.0
    ├── bdk-reserves 0.17.0
    │   └── bdk-cli 0.5.0
    └── bdk-cli 0.5.0

Notes to the reviewers

There is still one audit issue that I can't figure out how to fix, I created #85 to track it.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory self-assigned this Apr 28, 2022
@notmandatory notmandatory added the bug Something isn't working label Apr 28, 2022
@notmandatory notmandatory added this to the Release 0.5.x milestone Apr 28, 2022
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK e2743d1

@notmandatory notmandatory merged commit 9b2453f into bitcoindevkit:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants