-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for publishing to crates.io, rename bin to bdkwallet #8
Conversation
4e669f6
to
a3ba8e5
Compare
I am not strongly against renaming, however, I prefer btw, I think you have a typo in the description |
a3ba8e5
to
6e52278
Compare
Thanks for the feedback, consistency with similar tools makes sense. I updated this PR to use |
6e52278
to
467827b
Compare
467827b
to
eaba31c
Compare
I also updated the app name in the |
eaba31c
to
b9c452b
Compare
b9c452b
to
88f5725
Compare
I added two more commits, one to set the bdk and bdk_macros versions so that I can push this crate to crates.io. And one to fix a broken rustdocs link. If no objections I'll merge this PR tomorrow and then publish it. |
Description
In this PR I add some missing metadata to Cargo.toml to prepare for publishing to crates.io. I also renamed the
repl.rs
bin tobdk-cli
to be consistent with similar tools in other projects.Notes to the reviewers
See related PR to update the bitcoindevkit.org website docs to match updated
bdk-cli
.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing