Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for publishing to crates.io, rename bin to bdkwallet #8

Merged
merged 4 commits into from
Jan 8, 2021

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Jan 5, 2021

Description

In this PR I add some missing metadata to Cargo.toml to prepare for publishing to crates.io. I also renamed the repl.rs bin to bdk-cli to be consistent with similar tools in other projects.

Notes to the reviewers

See related PR to update the bitcoindevkit.org website docs to match updated bdk-cli.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@RCasatta
Copy link
Member

RCasatta commented Jan 6, 2021

I am not strongly against renaming, however, I prefer bdk-cli like other CLI tools such as bitcoin-cli or lightning-cli

btw, I think you have a typo in the description bdwallet instead of bdkwallet

@notmandatory
Copy link
Member Author

notmandatory commented Jan 6, 2021

I am not strongly against renaming, however, I prefer bdk-cli like other CLI tools such as bitcoin-cli or lightning-cli

btw, I think you have a typo in the description bdwallet instead of bdkwallet

Thanks for the feedback, consistency with similar tools makes sense. I updated this PR to use bdk-cli and will put in a corresponding PR to update the website to match.

@notmandatory notmandatory marked this pull request as ready for review January 6, 2021 17:48
@notmandatory
Copy link
Member Author

I also updated the app name in the --help to "BDK CLI".. last change I promise.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@notmandatory
Copy link
Member Author

I added two more commits, one to set the bdk and bdk_macros versions so that I can push this crate to crates.io. And one to fix a broken rustdocs link. If no objections I'll merge this PR tomorrow and then publish it.

Cargo.toml Outdated Show resolved Hide resolved
@notmandatory notmandatory merged commit f049dd2 into bitcoindevkit:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants