Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch address index in verbose mode for get_new_address #77

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

rajarshimaitra
Copy link
Contributor

Description

Fixes #40

cc @thunderbiscuit

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

@rajarshimaitra
Copy link
Contributor Author

@notmandatory does this requires changelog update?

@thunderbiscuit
Copy link
Member

tested ACK 73a9824.

@thunderbiscuit
Copy link
Member

Related but not related question: I think the verbose flag is not available in the repl. Is that something we could enable?

@rajarshimaitra
Copy link
Contributor Author

rajarshimaitra commented Mar 10, 2022

I haven't tried yet but from the code it seems verbose mode should be available to repl too..

CliSubCommand::Repl { wallet_opts } => {

Let me know if that's not the case.. Then it might need some fixing..

@thunderbiscuit
Copy link
Member

You're right. Took me a minute to figure it out, but my mistake was trying to call --verbose inside the repl (which throws an error). Instead the --verbose flag needs to be enabled when entering the repl, and will be "on" for all commands inside the loop.

Thanks!

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 73a9824

This one is OK without a changelog message, it doesn't break anything. But I might add one when we do the release.

@notmandatory notmandatory merged commit 8d14cf5 into bitcoindevkit:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Feature request: address index in verbose output
3 participants