-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to bdk 0.17.0 #73
Update to bdk 0.17.0 #73
Conversation
9a13c29
to
6766da9
Compare
I just saw your PR after making the issue.. Looks like you are already on it.. I will review once its ready.. Lets get this one done first.. |
@notmandatory let me know if you want me to take this on if you are busy in other parts.. I can try push it to finish line.. |
6766da9
to
735be18
Compare
Thanks Raj! it's ready to review now I'd appreciate your review. |
6d3c3ef
to
6c371b1
Compare
6c371b1
to
14cbbd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 14cbbd1
All changes looks good to me. This is ready to hit the party..
Below are few non blocking nits.. Nothing major, can be fixed later if needed..
Description
Fixes #81
Notes to the reviewers
Also added
verify
feature flag which enables transaction verification against consensus rules during sync.I also had to disable the
reserves
tests and that feature will be broken until we can get it updated to usebdk
0.17
also. I created an issue https://github.com/weareseba/bdk-reserves/issues/4.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md