-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codecov to grcov from Tarpauline #58
Update codecov to grcov from Tarpauline #58
Conversation
Although it seems we haven't been using the codecov reporting lately. There were no codecov reports for previous PRs. @notmandatory is this intentional or something was off with Tarpaulin? |
Looks like a something needs to be done to fix the failure seen here: https://github.com/rajarshimaitra/bdk-cli/runs/4340753274?check_suite_focus=true This project has a rustup override set nightly |
You mean no |
bcf4b9f
to
17c9329
Compare
I am not sure if we need the file. But for now I have set the override in CI.
Yes the coverage reports are generating fine, but they are not being displayed in PR page here. Also the same for bdk project. Maybe we need to add CodeCov App to github like this? https://docs.codecov.com/docs/how-to-create-a-github-app-for-codecov-enterprise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 17c9329
Also I think I've enabled the Codecov
app for the bitcoindevkit
org.. it should activate next time code is pushed to this repo.
This one looks like it needs a rebase to get it to rerun the tests for rust 1.56.1 and then we can merge it. |
17c9329
to
f8200a1
Compare
Rebased. |
Description
To match with existing codecov of BDK, Tarpaulin based codecov in bdk-cli is changed to grcov.
Notes to the reviewers
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing