Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/rust toolchain #34

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

DarthBenro008
Copy link
Contributor

Description

Fixes #27

Notes to the reviewers

  • Fixed a small Clippy warning and as mentioned in Rust Clippy in order to pass the build.
  • Adds Cargo.toml

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

@afilini
Copy link
Member

afilini commented Jul 16, 2021

FWIW I've confirmed locally that cargo build --features repl,electrum,esplora,compiler,compact_filters --bin bdk-cli produces the same Cargo.lock

@rajarshimaitra
Copy link
Contributor

tACK.

Verified cargo.lock is same.

@notmandatory
Copy link
Member

Sorry for the delay in merging I also had to do a rebase.

@notmandatory notmandatory merged commit c33f654 into bitcoindevkit:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce build toolchain?
4 participants