Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to the changed signing interface in bdk 0.7 #28

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

ulrichard
Copy link
Contributor

Description

Adapting to the current master branch of bdk.

After the next release of bdk, Cargo.toml, should go back to use crates.io

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory
Copy link
Member

I'd prefer to just update to the latest published bdk version ^0.7 which should have all the latest and greatest features. Or ^0.8 will be out soon if there's something you need that's not released yet.

@ulrichard
Copy link
Contributor Author

Ah yes. I was not aware that the changes of the signing functions are in a release already.

@ulrichard
Copy link
Contributor Author

ulrichard commented Jun 1, 2021

The CI failure is with rust 1.45.
In the BDK repo 1.46 is used instead.
Wouldn't it make sense to use the same versions?
And if so, where can this be adapted?

@ulrichard ulrichard force-pushed the foreign_utxo branch 2 times, most recently from cced0ac to e468795 Compare June 1, 2021 08:26
@ulrichard ulrichard changed the title adapt to the current master branch of bdk adapt to the changed signing interface in bdk 0.7 Jun 1, 2021
@notmandatory
Copy link
Member

notmandatory commented Jun 1, 2021

The reason bdk MSRV (minimum supported rust version) was changed to 1.46 is due to an issue with one of the dependencies (hyper), for more details see bitcoindevkit/bdk#317.

But to be in sync with bdk I don't see a problem incrementing the MSRV for bdk-cli also to 1.46. You just need to update it on line 14 of cont_integration.yml. Nevermind, I see you found it. To allow the merge I also need to update the GitHub "Required" checks.

@notmandatory notmandatory merged commit eb83d4c into bitcoindevkit:master Jun 2, 2021
@notmandatory
Copy link
Member

Thanks for the updates. I had to force-push to rebase on the lastest master changes. I also fixed up the CHANGELOG.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants