Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As BDK bumped its stable to 1.65, it is safe for us to move it up also.
Notes to the reviewers
1.65
cause clippy warning thatEq
isn't derived whilePartialEq
is derived for the commands. We can't deriveEq
for commands, as there is afee_rate
which isf32
which isn'tEq
, and this effect cascades to all structures. We also needPartialEq
for the tests.A few options were:
allow the clippy warning conditionally for
1.65
,1.57
doesn't have that lint. The way to do that is by creating custom features for different versions and making a build script that activates specific features for specific versions. Feature gate the clippy lint. or use https://github.com/dtolnay/rustversion which is an extra dep.Remove
PartialEq
and create a method onCliOpts
to translate it intoVec<String>
, and then perform the tests.Make
fee_rate
u32
and deriveEq
for all.I went for the last option as it seemed less complex, and not too bad(?). For bdk_cli as majorly a testing tool, it might not need floating point granularity and users can still test out with
u32
fee_rates. Internally it converts it back tof32
.Suggestions welcome.
Changelog notice
stable
to 1.65.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing