-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bdk cli for wasm #117
Update bdk cli for wasm #117
Conversation
54d4804
to
83d1a6d
Compare
ed81264
to
4b51d4f
Compare
be73ab5
to
2ca6a91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add a CI job for wasm (just building the code, no tests) so that we don't forget to keep this updated going forward
44a04ec
to
eef619e
Compare
I added this to the 0.7.0 milestone since it's the next big thing worth making a release for. |
The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :) |
Add a module "wasm" with utilities to be used in the bdk playground: - A WasmWallet structure, to create a wallet and run commands - A compile function, to compile policies into descriptors
eef619e
to
edb270c
Compare
Hey sorry I just saw this comment. If this one is just about ready to go then probably better to put it in 0.6.0 then have to do a 0.7.0 right after 0.6.0. That sound OK @rajarshimaitra ? |
Sounds good to me.. If this is almost ready we can push it in 0.6.. I will put in a review too soon.. |
On the initial look the code LGTM.. I just have one conceptual question.. Is there any wasm related technical problem of just using this function here and expose it via bindgen? Line 533 in 183e85e
All the wallet structures and everything else is created internally within this function, so in theory we won't need to have dedicated wasm related structure definition. That was my motivation behind simplifying the I haven't tried this out myself, so wondering if there's something specific to wasm that doesn't allow us to do that?? The purpose of |
For sure the type is not compatible with wasm, you can't get a The second issue is that in wasm only the |
Thanks @afilini ya that makes sense.. So there is no easy way to do this without the extra structures.. This one is good to go modulo your comments.. Or can they be added in separate PR and we merge this for the next release? |
edb270c
to
731dc74
Compare
+1, and also creating the db/blockchain requires creating directories (see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 731dc74
Description
This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118
Notes to the reviewers
Based on #116
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md
Bugfixes: