depends: Switch from multilib to platform-specific toolchains #32162
+29
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32162. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
hebasto
force-pushed
the
250329-cross
branch
2 times, most recently
from
4bf8e8f to
1925dc1
Compare
This was referenced Mar 29, 2025
Merged
laanwj
reviewed
Mar 31, 2025
laanwj
reviewed
Mar 31, 2025
| @@ -6,11 +6,12 @@ | |||
|
|
|||
| export LC_ALL=C.UTF-8 | |||
|
|
|||
| export HOST=i686-pc-linux-gnu | |||
| export HOST=i686-linux-gnu | |||
Member
There was a problem hiding this comment.
i've always been confused about the -pc- in the architecture tuple-is it directly related to use (or non-use) of multilib?
Member
Author
There was a problem hiding this comment.
It's hard to say.
Referring to x86_64-pc-linux-gnu is still necessary when building depends natively on x86_64, because:
$ uname -m
x86_64
$ ./depends/config.sub $(./depends/config.guess)
x86_64-pc-linux-gnu
However, dropping the -pc- infix helped to with Clang's paths in the OSS-Fuzz environment.
Member
There was a problem hiding this comment.
Hrm, yea, config.sub adds it for x86 archs (but unknown for others) so it's likely canonical somehow.
$ ./config.sub i386-linux-gnu
i386-pc-linux-gnu
$ ./config.sub x86_64-linux-gnu
x86_64-pc-linux-gnu
$ ./config.sub arm-linux-gnueabihf
arm-unknown-linux-gnueabihf
$ ./config.sub riscv64-linux-gnu
riscv64-unknown-linux-gnu
But seems fine to leave it out in the README.md because it doesn't include the -unknown- infixes either.
Member
Author
There was a problem hiding this comment.
Also, please note that depends/README.md lists triplets after specifically mentioning "for cross compilation". In such cases:
bitcoin/depends/hosts/default.mk
Lines 1 to 3 in 4c1906a
-pc- infix.
Member
|
Concept ACK, multilib is more or less specific to x86, it's better if multi-platform is handled in a more architecture-agnostic and consistent way. |
This was referenced Mar 31, 2025
Member
Author
|
Rebased due to a conflict with the merged #30997. |
Contributor
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use] |
Member
Author
|
Rebased due to a conflict with the merged #32086. |
maflcko
reviewed
May 6, 2025
Contributor
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use] |
Member
Author
|
My Guix build: |
Contributor
BrandonOdiwuor
left a comment
BrandonOdiwuor
left a comment
There was a problem hiding this comment.
Approach ACK 5f061f5
Tested Linux ARM64 to x86_64 cross-compilation in Docker on MacOS 26.0 host. Builds succeeded without multilib
Building on Ubuntu 22.04 arm64
$ sudo apt install g++-x86-64-linux-gnu binutils-x86-64-linux-gnu
$ export HOST=x86_64-linux-gnu
$ gmake -C depends -j $(nproc)
$ cmake -B build-${HOST} --toolchain depends/${HOST}/toolchain.cmake
$ cmake --build build-${HOST} -j $(nproc)
Testing on Ubuntu 22.04 x86_64
hebasto
force-pushed
the
250329-cross
branch
from
5f061f5 to
3e69b69
Compare
Member
Author
|
Rebased to resolve a conflict with the merged #31802. |
Member
Author
|
My Guix build: |
Member
Author
|
Rebased to resolve a conflict with the merged #33549. |
maflcko
reviewed
Oct 15, 2025
Member
Author
|
My Guix build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the multilib GCC toolchain, as currently documented in
depends/README.md, has several issues, such as:The
g++-multilibpackage conflicts with platform-specific cross-compiler packages. This means it is not possible to cross compile fori686and other platforms using the same set of installed packages.The
g++-multilibpackage is not available forarm64:This PR addresses all the issues mentioned above by switching from multilib to platform-specific toolchains.
Also see #22456.
Here are examples of building for different scenarions:
x86_64orarm64, building with depends natively:x86_64orarm64, cross compiling fori686-pc-linux-gnu:x86_64, cross compiling forarm64:arm64, cross compiling forx86_64: