test: Display skipped tests reason #26031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouloumos
reviewed
Sep 7, 2022
There was a problem hiding this comment.
ACK f5a46ab, looks good and it definitely adds more context to someone running the functional tests to better understand why those tests are skipped.
Note: As most of the skip_test_if_missing_module checks are based on ./configuration options, reviewers can check for different skip reasons just with different configuration parameters instead of re-building.
|
Concept ACK |
maflcko
approved these changes
Sep 8, 2022
aureleoules
force-pushed
the
2022-09-print-test-skip-reason
branch
from
f5a46ab to
07b6e74
Compare
brunoerg
approved these changes
Sep 8, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 11, 2022
07b6e74 test: Display skipped tests reason (Aurèle Oulès) Pull request description: Attempt to fix bitcoin#26023. ACKs for top commit: brunoerg: ACK 07b6e74 Tree-SHA512: 5d8f7fbd8d65772000a5da8c01276948b157d93d359203c6442cf2681cdcc2426b1fee7ec62cee100019c59a486a96ad98d5e819bffe1fd37624dcd28f42aed2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #26023.