refactor: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code
#25148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK, good idea. |
|
LGTM |
|
Post-merge ACK a55db4e |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 28, 2022
…m non-test/benchmarking code a55db4e Add more proper thread safety annotations (Hennadii Stepanov) 8cfe93e Add proper thread safety annotation to `CWallet::GetTxConflicts()` (Hennadii Stepanov) ca446f2 Add proper thread safety annotation to `CachedTxGetAvailableCredit()` (Hennadii Stepanov) Pull request description: In non-test/benchmarking code, there are three cases of the `NO_THREAD_SAFETY_ANALYSIS` annotation which are accompanied with `TODO` comments. This PR adds proper thread safety annotations instead of `NO_THREAD_SAFETY_ANALYSIS`. ACKs for top commit: laanwj: Code review ACK a55db4e Tree-SHA512: 806d72eebc1edf088bfa435c8cd11465be0de6789798dd92abd008425516768acb864a73d834a49d412bb10f7fccfb47473f998cb72739dab6caeef6bcfaf191
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 8, 2022
Summary: This is a backport of [[bitcoin/bitcoin#25148 | core#25148]] Depends on D12784 Notes: - there is one more occurence of NO_THREAD_SAFETY_ANALYSIS in avalanche/processor.cpp - `CWallet::IsSpent` and `CWallet::ReacceptWalletTransaction` already had the annotation, so I also added the assertion (this is still not done on Core's master branch) Test Plan: With Debug and TSAN `ninja all check check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D12809
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In non-test/benchmarking code, there are three cases of the
NO_THREAD_SAFETY_ANALYSISannotation which are accompanied withTODOcomments.This PR adds proper thread safety annotations instead of
NO_THREAD_SAFETY_ANALYSIS.