Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd docs correctness #16346

Closed
hebasto opened this issue Jul 5, 2019 · 3 comments · Fixed by #18157
Closed

systemd docs correctness #16346

hebasto opened this issue Jul 5, 2019 · 3 comments · Fixed by #18157
Labels
Docs good first issue

Comments

@hebasto
Copy link
Member

hebasto commented Jul 5, 2019

It seems this part of doc/init.md:

At a bare minimum, bitcoind requires that the rpcpassword setting be set when running as a daemon. If the configuration file does not exist or this setting is not set, bitcoind will shut down promptly after startup.

is no longer the true. Or did I miss something?
@fanquake fanquake added the Docs label Jul 7, 2019
@maflcko
Copy link
Member

maflcko commented Jul 8, 2019 •
edited
Loading

You can check when the documentation was added (git blame or git log -S 'some string'), and then read the source code for that commit:

bitcoin/src/rpcserver.cpp

Line 542 in 234bfbf

_("%s, you must set a rpcpassword in the configuration file:\n"

To find out when that error was removed, you can run git log -S 'some string' again:

git log -S 'rpcpassword in the configuration f'

It will spit out 71cbeaa

Looks like in master, the message was moved to the cli:

https://github.com/bitcoin/bitcoin/blame/c799976c86e2d65f129d106724fbefbf665d63d4/src/bitcoin-cli.cpp#L378

@cvengler
Copy link
Contributor

I setted up a bitcoind on systemd a week ago.
The server parameter was not enabled therefore an rpcpassword was not set and it worked like a charm (for systemd conditions)

@jkcd jkcd mentioned this issue Feb 16, 2020
Merged
@jkcd
Copy link

jkcd commented Feb 16, 2020

Raised a PR 18157 to fix it.

sidhujag pushed a commit to syscoin/syscoin that referenced this issue Apr 24, 2020
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
6b464cf 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 17, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
4e468f5 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 26, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
8727d33 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 26, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
e515dd5 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 26, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
b3f5a8c 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 27, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
35c12a4 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 28, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
0fa560b 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 29, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
952bfd9 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 29, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
031596f 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 1, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
f578f40 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 3, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
98e9b05 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 4, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
4e3f4d8 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 4, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
0163950 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 5, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
0010db0 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 8, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
58a89e6 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 9, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
deb4fd3 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 11, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
9773b4a 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 11, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
0d08908 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Sep 16, 2022
@vijaydasmp
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
3dde9ab 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
ogabrielides pushed a commit to ogabrielides/dash that referenced this issue Sep 26, 2022
@ogabrielides
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
7476984 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
michaelvkax pushed a commit to vkaxproject/vkax that referenced this issue Oct 22, 2022
@michaeldickkk
Merge bitcoin#18157: doc: fixing init.md documentation to not require…
f52e2cf 
… rpcpassword

a2a03c3 fixing documentation to not require rpcpassword (“jkcd”)

Pull request description:

  Configuration section in [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md) says user must set rpcpassword in order to run bitcoind. Since [71cbea](bitcoin@71cbeaa) fixed the code to use a cookie for authentication, it is not mandatory to set rpcpassword in the configuration.

  Fixes bitcoin#16346

ACKs for top commit:
  hebasto:
    ACK a2a03c3, modulo nit

Tree-SHA512: a62816fef78bed32200bb278cfc7aacf6ea154a60fdf5181927e48b806a1bd694bdf3ccec8362f5e58aad694d636c63f540323d54d85b61deaa417b95b8b56eb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Docs good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fixing init.md documentation to not require rpcpassword jkcontrib/bitcoin
5 participants
@fanquake @maflcko @cvengler @jkcd @hebasto