scripts/diffcheck.sh: Use secure temp files and git archive for better safety #1924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Aug 12, 2025
There was a problem hiding this comment.
LGTM, but I'm not a bash expert. Pinging file authors @kallewoof @achow101 for feedback.
|
I didn't really write that code. The reason I'm on blame is because of the move that happened in #1432. That said, this PR seems to unnecessarily complicate things. This script is meant to be run in Github Actions. It's not meant to be run by users, and doesn't need "better safety". I have no strong opinion on the subject though so if others think this is useful, go ahead. |
|
Thank you for the feedback @kallewoof. |
katesalazar
reviewed
Sep 29, 2025
| diff README.mediawiki "$table_file" | grep '^[<>] |' >"$after_diff" || true | ||
|
|
||
| # Build table from previous commit without altering the working tree | ||
| if git archive --format=tar HEAD^ | tar -x -C "$prev_dir" && perl "$prev_dir/scripts/buildtable.pl" >"$table_prev_file" 2>/dev/null; then |
There was a problem hiding this comment.
Does this run the previous rev script with the current rev contents?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
scripts/diffcheck.shto improve security and reliability by replacing fixed/tmppaths with secure temporary directories and avoiding destructivegit checkout.Changes
mktemp -dwith automatic cleanup viatrapinstead of hardcoded/tmppathsgit checkout HEAD^withgit archiveto avoid modifying working tree state