Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-0094: add default p2p port for testnet4 #1781

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

Roasbeef
Copy link
Contributor

@Roasbeef Roasbeef commented Mar 6, 2025

No description provided.

@jonatack jonatack added Proposed BIP modification Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified labels Mar 6, 2025
@jonatack
Copy link
Member

jonatack commented Mar 6, 2025

cc @fjahr

@fjahr
Copy link
Contributor

fjahr commented Mar 7, 2025

ACK fcd5d72

Didn't occur to me that this should be in the BIP but probably a good info to have.

@jonatack jonatack removed the Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified label Mar 7, 2025
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fcd5d72

48333 is already the default port used by Bitcoin Core (in src/kernel/chainparams.cpp#CTestNet4Params -> nDefaultPort = 48333;).

Verified this is not already specified in the current BIP draft.

@jonatack jonatack merged commit 61a39ce into bitcoin:master Mar 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants