New Card for BDP #46
Merged
New Card for BDP #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0tuedon
force-pushed
the
tt-new-card
branch
2 times, most recently
from
f00f2fa to
f554071
Compare
jrakibi
reviewed
Nov 4, 2025
dist/search-icon-HDCX3UXV.svg
Outdated
There was a problem hiding this comment.
do we need to have this file in dist folder ?
There was a problem hiding this comment.
I think it can be removed, but when we do a yarn build it will be back
There was a problem hiding this comment.
a yarn build it will be back
it won't be back to version control
I think its a build artifact that shouldnt be comitted
maybe we can add also dist/*.svg to .gitignore to avoid this in th future
jrakibi
approved these changes
Nov 4, 2025
jrakibi
added a commit
that referenced
this pull request
Nov 4, 2025
* feat: add Search component * add PropTypes validation and fix linter errors (#43) * add PropTypes validation and fix linter errors * run formatter * fix typo * Add Icons and tags (#44) * Add icons * Add tags * add accidentally deleted icons * run formatter for all files * add args to fix typecheck errors * Add pills (#45) * add pills * format code * feat: New Card for BDP (#46) * chore(new-components): new componens from branding * feat(card): bdp card addition * chore:initial commit * --amend --------- Co-authored-by: 0tuedon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.