doc: add ctime_tests usage instructions to README#1803
Closed
8144225309 wants to merge 1 commit intobitcoin-core:masterfrom
Closed
doc: add ctime_tests usage instructions to README#18038144225309 wants to merge 1 commit intobitcoin-core:masterfrom
8144225309 wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
The usage hint in ctime_tests.c suggests libtool, which only applies to Autotools builds. Point to README.md instead. Fixes bitcoin-core#1697
Member
|
Concept ACK. |
Contributor
Author
|
do you like this style better or #1804 ?? |
Contributor
|
I prefer #1804. |
real-or-random
added
tweak/refactor
meta/development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When building with CMake and running
ctime_tests, users see a message suggestinglibtool, which is Autotools-specific:Before
This is confusing for CMake users since they don't have libtool. Reported in #1697.
Solution
Following the approach in #1778, replace the build-system-specific command with a pointer to README.md and document both methods there.
After
The README now includes instructions for both build systems.
Fixes #1697