Drop unneeded include directory #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No headers reside in the `${CMAKE_CURRENT_SOURCE_DIR}/src>` directory.
No changes in behavior.
ryanofsky
approved these changes
Aug 31, 2022
Collaborator
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
Code review ACK d36ebb9. I'm not sure about this change in the long term since in the future maybe the code generator should have private headers that are not installed. But this is ok for now, and maybe code would move around anyway and make this obsolete.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No headers reside in the
${CMAKE_CURRENT_SOURCE_DIR}/src>directory.No changes in behavior.