Skip to content

Avoid using boost::optional in PassField() #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Avoid using boost::optional in PassField() #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions include/mp/proxy-types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,22 +955,26 @@ void CustomBuildField(TypeList<LocalType> local_type,
template <typename Accessor, typename LocalType, typename ServerContext, typename Fn, typename... Args>
void PassField(TypeList<LocalType*>, ServerContext& server_context, const Fn& fn, Args&&... args)
{
InvokeContext& invoke_context = server_context;
boost::optional<Decay<LocalType>> param;
const auto& params = server_context.call_context.getParams();
const auto& input = Make<StructField, Accessor>(params);
bool want = input.want();
if (want) {
MaybeReadField(std::integral_constant<bool, Accessor::in>(), TypeList<LocalType>(), invoke_context, input,
Emplace<decltype(param)>(param));
if (!param) param.emplace();

if (!input.want()) {
fn.invoke(server_context, std::forward<Args>(args)..., nullptr);
server_context.call_context.getResults();
return;
}
fn.invoke(server_context, std::forward<Args>(args)..., param ? &*param : nullptr);

InvokeContext& invoke_context = server_context;
Decay<LocalType> param;

MaybeReadField(std::integral_constant<bool, Accessor::in>(), TypeList<LocalType>(), invoke_context, input,
Emplace<decltype(param)>(param));

fn.invoke(server_context, std::forward<Args>(args)..., &param);

auto&& results = server_context.call_context.getResults();
if (want) {
MaybeBuildField(std::integral_constant<bool, Accessor::out>(), TypeList<LocalType>(), invoke_context,
Make<StructField, Accessor>(results), *param);
}
MaybeBuildField(std::integral_constant<bool, Accessor::out>(), TypeList<LocalType>(), invoke_context,
Make<StructField, Accessor>(results), param);
}

template <typename Accessor, typename LocalType, typename ServerContext, typename Fn, typename... Args>
Expand Down