Skip to content

Address clang-tidy-19 warnings #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Address clang-tidy-19 warnings #144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a692038
cmake: Skip linting for generated sources
hebasto Jan 31, 2025
3c07ab8
clang-tidy: Disable `misc-use-anonymous-namespace` check
hebasto Jan 31, 2025
d6523b6
clang-tidy: Disable `performance-avoid-endl` check
hebasto Jan 31, 2025
1cc0bf5
clang-tidy: Fix `bugprone-crtp-constructor-accessibility` check
hebasto Jan 31, 2025
5a15744
clang-tidy: Suppress `bugprone-empty-catch` check warning
hebasto Jan 31, 2025
f983b09
clang-tidy: Fix `modernize-type-traits` check
hebasto Jan 31, 2025
06806fe
clang-tidy: Fix `misc-const-correctness` check
hebasto Jan 31, 2025
90cb5a9
clang-tidy: Fix `misc-include-cleaner` check
hebasto Jan 31, 2025
2ad6c17
clang-tidy: Fix `misc-use-internal-linkage` check
hebasto Jan 31, 2025
584f3e2
clang-tidy: Fix `performance-unnecessary-value-param` check
hebasto Jan 31, 2025
fa265a9
clang-tidy: Fix `readability-avoid-nested-conditional-operator` check
hebasto Jan 31, 2025
f159c75
clang-tidy: Fix `readability-avoid-return-with-void-value` check
hebasto Jan 31, 2025
3418ad2
clang-tidy: Fix `readability-container-size-empty` check
hebasto Jan 31, 2025
19d7537
clang-tidy: Suppress `performance-enum-size` check warning
hebasto Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ configure_file(include/mp/config.h.in "${CMAKE_CURRENT_BINARY_DIR}/include/mp/co

# Generated C++ Capn'Proto schema files
capnp_generate_cpp(MP_PROXY_SRCS MP_PROXY_HDRS include/mp/proxy.capnp)
set_source_files_properties(${MP_PROXY_SRCS} PROPERTIES SKIP_LINTING ON)

# util library
add_library(mputil OBJECT src/mp/util.cpp)
Expand Down
16 changes: 9 additions & 7 deletions cmake/TargetCapnpSources.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,20 @@ function(target_capnp_sources target include_prefix)

set(generated_headers "")
foreach(capnp_file IN LISTS TCS_UNPARSED_ARGUMENTS)
add_custom_command(
OUTPUT ${capnp_file}.c++ ${capnp_file}.h ${capnp_file}.proxy-client.c++ ${capnp_file}.proxy-types.h ${capnp_file}.proxy-server.c++ ${capnp_file}.proxy-types.c++ ${capnp_file}.proxy.h
COMMAND Libmultiprocess::mpgen ${CMAKE_CURRENT_SOURCE_DIR} ${include_prefix} ${CMAKE_CURRENT_SOURCE_DIR}/${capnp_file} ${TCS_IMPORT_PATHS} ${MP_INCLUDE_DIR}
DEPENDS ${capnp_file}
VERBATIM
)
target_sources(${target} PRIVATE
set(generated_sources
${CMAKE_CURRENT_BINARY_DIR}/${capnp_file}.c++
${CMAKE_CURRENT_BINARY_DIR}/${capnp_file}.proxy-client.c++
${CMAKE_CURRENT_BINARY_DIR}/${capnp_file}.proxy-server.c++
${CMAKE_CURRENT_BINARY_DIR}/${capnp_file}.proxy-types.c++
)
add_custom_command(
OUTPUT ${generated_sources} ${capnp_file}.h ${capnp_file}.proxy-types.h ${capnp_file}.proxy.h
COMMAND Libmultiprocess::mpgen ${CMAKE_CURRENT_SOURCE_DIR} ${include_prefix} ${CMAKE_CURRENT_SOURCE_DIR}/${capnp_file} ${TCS_IMPORT_PATHS} ${MP_INCLUDE_DIR}
DEPENDS ${capnp_file}
VERBATIM
)
target_sources(${target} PRIVATE ${generated_sources})
set_source_files_properties(${generated_sources} PROPERTIES SKIP_LINTING ON)
Copy link
Collaborator

@ryanofsky ryanofsky Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit "cmake: Skip linting for generated sources" (a692038)

I think my preference would be to not skip linting for generated files, and I implemented changes locally to actually fix the lint errors, so I think it would be slightly better to drop this commit to avoid having to undo this later. This commit also conflicts with #142 so that could be another reason to drop it. Ok to keep though if you prefer. Just pointing out that this may change later.


list(APPEND generated_headers ${capnp_file}.h)
endforeach()
Expand Down