Make clang-tidy happy

[vasild]

• Get https://include-what-you-use.org/ happy with this project
  clang-tidy supersedes this
• Integrate it either into make test or its own make iwyu
clang-tidy is executed when compiling
• Fix or suppress existent warnings; done in Address clang-tidy-19 warnings #144
• Consider some CI to run it automatically per pull request to catch future regressions

[purpleKarrot]

This may be regarded as obsolete/reduntant with clang-tidy's include-fixer check.

[vasild]

CMakeLists.txt only sets set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_EXECUTABLE}") and never actually executes clang-tidy?

[hebasto]

CMakeLists.txt only sets set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_EXECUTABLE}") and never actually executes clang-tidy?

It does. You can check it out using --verbose.

[vasild]

Right!

src/mp/util.cpp:9:1: warning: included header array.h is not used directly [misc-include-cleaner]
    9 | #include <kj/array.h>
      | ^~~~~~~~~~~~~~~~~~~~~
   10 | #include <pthread.h>

I updated the OP.

[hebasto]

I updated the OP.

Did you see #144?

[vasild]

I updated the OP.

Did you see #144?

Before no, but now yes. Updated the OP even more :)