Set peer version and subversion to N/A when not available or detecting #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
Contributor
|
lgtm ACK b261100 |
stickies-v
added a commit
to stickies-v/py-bitcoinkernel
that referenced
this pull request
Jan 27, 2026
8593d965191e Merge bitcoin/bitcoin#33067: test: refactor ValidWitnessMalleatedTx class to helper function 34a5ecadd720 Merge bitcoin/bitcoin#34397: doc: fix arg name hints so bugprone can validate them 1cc58d3a0c65 Merge bitcoin/bitcoin#34281: build: Temporarily remove confusing and brittle `-fdebug-prefix-map` 2778eb46647a Merge bitcoin/bitcoin#34337: fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration() d70fb8a5754f Merge bitcoin/bitcoin#34351: util: Remove `FilterHeaderHasher` 6472ba06c36a Merge bitcoin/bitcoin#34388: doc: Explain that low-effort pull requests may be closed 5f66fca633c8 Merge bitcoin-core/gui#920: Set peer version and subversion to N/A when not available or detecting 02240a7698e3 Merge bitcoin/bitcoin#34390: test: allow overriding `tar` in `get_previous_releases.py` a73a3ec5532d doc: fix invalid arg name hints for bugprone validation 5b8c204275aa Merge bitcoin/bitcoin#34384: Remove epoch logic from mempool eeee3755f8c4 fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration() fa15a8d2d03b doc: Explain that low-effort pull requests may be closed be2b48b9f3e5 test: allow overriding tar in get_previous_releases 891030ac8b9e Merge bitcoin/bitcoin#33822: kernel: Add block header support and validation 0871e104a26d Merge bitcoin/bitcoin#34242: Prepare string and net utils for future HTTP operations 1b079becf14d Merge bitcoin/bitcoin#34317: fuzz: Exclude too expensive inputs in descriptor_parse targets cdb42a8df8cd Merge bitcoin/bitcoin#34380: test: Fix P2PK script test 40735450c00b Remove unused epochguard.h 1a8494d16c7b Rework CTxMemPool::GetChildren() to not use epochs 7b48b09b7f77 Merge bitcoin/bitcoin#34376: bench/test: clarify merkle bench and witness test intent fab2f3df4beb fuzz: Exclude too expensive inputs in descriptor_parse targets 1911db8c6dc6 string: add LineReader ee62405cce2b time: implement and test RFC1123 timestamp string eea38787b9be string: add AsciiCaseInsensitive{KeyEqual, Hash} for unordered map 1d8cb78d5b1c Merge bitcoin/bitcoin#34309: guix: stop passing depends sources to codesigning 4e300df7123a string: add `base` argument for ToIntegral to operate on hexadecimal 0b0d9125c19c Modernize GetBindAddress() 7041648ee5bd Merge bitcoin/bitcoin#34375: doc: mempool: fix `removeUnchecked` incorrect comment 9a9d797ef6ed kernel: Add support for block headers 1137debb8530 doc: mempool: fix `removeUnchecked` incorrect comment c9ce1c7c4a12 test: Fix P2PK script test 691dc830c669 Merge bitcoin/bitcoin#34377: test: Rename wallet in restore attempt in wallet_assumeutxo d7fd8c6952f2 Merge bitcoin/bitcoin#34090: net: Fix `-Wmissing-braces` 1fbbdd20cde9 Merge bitcoin/bitcoin#34355: doc: Fix wrong code in WITH_LOCK doxygen comment 9016858282b6 Merge bitcoin/bitcoin#34297: p2p: add validation checks for initial self-announcement e1dc4afeeb6b test: Rename wallet name in restore attempt in wallet_assumeutxo 8b9d30e3facf bench/test: clarify merkle bench and witness test intent 5715748333fe Merge bitcoin/bitcoin#34366: test: switch order of error code and message check 2a1234001c46 Merge bitcoin/bitcoin#34269: wallet: disallow creating new or restoring to an unnamed (default) wallet 3ea2b6fe180e Merge bitcoin/bitcoin#34369: test: Scale NetworkThread close timeout with timeout_factor fab055c907f1 test: Scale NetworkThread close timeout with timeout_factor e324925d1990 Merge bitcoin/bitcoin#34363: Update libmultiprocess subtree to avoid occasional rpc_misc.py timeout fa267551c4ea Merge bitcoin/bitcoin#34353: refactor: Use std::bind_front over std::bind b851ff6cae71 kernel: Add Handle/View pattern for BlockValidationState fa61fadad1c3 doc: Fix wrong code in WITH_LOCK doxygen comment 52096de2121d Merge bitcoin/bitcoin#34032: util: Add some more Unexpected and Expected methods 0aba464ce765 test: switch order of error code and message check 3f5211cba8e7 test: remove child_one/child_two (w)txid variables 7cfe790820cf test: replace ValidWitnessMalleatedTx class with function 8c07800b193e Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count a365c9fe1fc3 Merge bitcoin/bitcoin#33738: log: avoid collecting `GetSerializeSize` data when compact block logging is disabled bc3c4cd8b235 Merge bitcoin/bitcoin#32724: Musig2 tests f7e88e298aed Merge bitcoin/bitcoin#32471: wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key ccf9172ab3bb util: Remove `FilterHeaderHasher` 7f5ebef56a0f Merge bitcoin/bitcoin#34302: fuzz: Restore SendMessages coverage in process_message(s) fuzz targets a6e8cd306eae Merge bitcoin/bitcoin#34310: iwyu: Add missed line to IWYU patch f4413706f9d4 Merge bitcoin/bitcoin#34344: ci: update GitHub Actions versions faa18dceba1d refactor: Use std::bind_front over std::bind 81675a781f3a test: use pre-generated chain 969c840db52d log,blocks: avoid `ComputeTotalSize` and `GetHash` work when logging is disabled babfda332b6a log,net: avoid `ComputeTotalSize` when logging is disabled 1658b8f82b99 refactor: rename `CTransaction::GetTotalSize` to signal that it's not cached 75b704df9d5c wallettool: Disallow creating new unnamed wallets 5875a9c50263 wallet: disallow unnamed wallets in createwallet and restorewallet 9482f00df0b0 chore: Update outdated GitHub Actions versions faa5a9ebad15 fuzz: Use min option in ConsumeTime de509c6df979 iwyu: Add missed line to IWYU patch faa59b367985 util: Add Expected::swap() fabb47e4e3db util: Implement Expected::operator*()&& d94d7b1a4b70 guix: stop passing depends sources to codesigning fab9721430aa util: Implement Expected::value()&& and Expected::error()&& fac480095986 util: Add Expected<void, E> specialization fa6575d6c2d2 util: Make Expected::value() throw fabf8d1c5bdb fuzz: Restore SendMessages coverage in process_message(s) fuzz targets fac7fed397f0 refactor: Use std::reference_wrapper<AddrMan> in Connman 6a8dbf9b9352 p2p: add validation check for initial self-announcement fa37928536e0 build: Temporarily remove confusing and brittle -fdebug-prefix-map d30ad4a9129d wallet, rpc: Use HandleWalletError in createwallet 73d0fe62d3db Merge commit '7562e2aeed95b0dc627e8e3a849941992f0189bb' into pr/subtree-7 7562e2aeed95 Squashed 'src/ipc/libmultiprocess/' changes from a4f92969649..1fc65008f7d a0ca851d26f8 Make GetBindAddress() callable from outside net.cpp 9c7e4771b13d test: Test listdescs with priv works even with missing priv keys ed945a685473 walletrpc: reject listdes with priv key on w-only wallets 9e5e9824f11b descriptor: ToPrivateString() pass if at least 1 priv key exists 5c4db25b61d4 descriptor: refactor ToPrivateString for providers 2dc74e3f4e5e wallet/migration: use HavePrivateKeys in place of ToPrivateString e842eb90bb6d descriptors: add HavePrivateKeys() a3c71c720158 [test] Add BIP 328 test vectors for Musig2 3dd815f048c8 validation: pre-reserve leaves to prevent reallocs with odd vtx count 7fd47e0e5608 bench: make `MerkleRoot` benchmark more representative b261100e7169 [qt] Set peer version and subversion to N/A when not available or detecting f46e3ec0f956 net: Fix `-Wmissing-braces` f0a218310874 test: adjust `ComputeMerkleRoot` tests fa1de1103fe5 util: Add Unexpected::error() faa109f8be7f test: refactor: Use BOOST_CHECK_EQUAL over BOOST_CHECK == fad4a9fe2b8d Set bugprone-unused-return-value.AllowCastToVoid git-subtree-dir: depend/bitcoin git-subtree-split: 8593d965191e1c0860614dec122e02ac2f91d031
sedited
added a commit
to sedited/rust-bitcoinkernel
that referenced
this pull request
Jan 27, 2026
…07a42ca43ed d07a42ca43ed Add sans utxo set block validation 00da3f047017 doc: Add docstrings for ConnectBlock and SpendBlock 1c16831a2fc2 validation: Move coin existence and spend check to SpendBlock 023ad3f66158 validation: Move SetBestBlock out of ConnectBlock d49b24250048 validation: Add SpendBlock function 702df0169535 validation: Use vector of outputs instead of CCoinsViewCache in CheckInputScripts 2f907b9e230f consensus: Use Coin span in CheckTxInputs 1b78755de266 consensus: Use Coin span in GetTransactionSigOpCost ccdcbd82ae3e consensus: Use Coin span in GetP2SHSigOpCount 27aeeff63014 Merge bitcoin/bitcoin#34328: rpc: make `uptime` monotonic across NTP jumps f970cb39fb64 Merge bitcoin/bitcoin#34267: net: avoid unconditional `privatebroadcast` logging (+ warn for debug logs) 8593d965191e Merge bitcoin/bitcoin#33067: test: refactor ValidWitnessMalleatedTx class to helper function 34a5ecadd720 Merge bitcoin/bitcoin#34397: doc: fix arg name hints so bugprone can validate them 1cc58d3a0c65 Merge bitcoin/bitcoin#34281: build: Temporarily remove confusing and brittle `-fdebug-prefix-map` 2778eb46647a Merge bitcoin/bitcoin#34337: fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration() d70fb8a5754f Merge bitcoin/bitcoin#34351: util: Remove `FilterHeaderHasher` 6472ba06c36a Merge bitcoin/bitcoin#34388: doc: Explain that low-effort pull requests may be closed 5f66fca633c8 Merge bitcoin-core/gui#920: Set peer version and subversion to N/A when not available or detecting 02240a7698e3 Merge bitcoin/bitcoin#34390: test: allow overriding `tar` in `get_previous_releases.py` a73a3ec5532d doc: fix invalid arg name hints for bugprone validation eeee3755f8c4 fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration() fa15a8d2d03b doc: Explain that low-effort pull requests may be closed be2b48b9f3e5 test: allow overriding tar in get_previous_releases 3f5211cba8e7 test: remove child_one/child_two (w)txid variables 7cfe790820cf test: replace ValidWitnessMalleatedTx class with function ccf9172ab3bb util: Remove `FilterHeaderHasher` 81675a781f3a test: use pre-generated chain 14f99cfe53f0 rpc: make `uptime` monotonic across NTP jumps a9440b1595be util: add `TicksSeconds` faa5a9ebad15 fuzz: Use min option in ConsumeTime fa37928536e0 build: Temporarily remove confusing and brittle -fdebug-prefix-map b39291f4cde0 doc: fix `-logips` description to clarify that non-debug logs can also contain IP addresses c7028d3368e9 init: log that additional logs may contain privacy-sensitive information 31b771a9425d net: move `privatebroadcast` logs to debug category b261100e7169 [qt] Set peer version and subversion to N/A when not available or detecting git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: d07a42ca43edd620bcfee8108b440b0cdf867bec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the debug console peer detail window, display "N/A" for the User Agent and Version when the peer is still detecting or the information is unavailable, instead of retaining the previous values.