-
Notifications
You must be signed in to change notification settings - Fork 328
Add translatable address error message #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| <item row="2" column="1"> | ||
| <widget class="QLabel" name="errorMessage"> | ||
| <property name="styleSheet"> | ||
| <string notr="true">color:red;</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is hardcoded red color visually compatible with dark themes/appearance? Maybe add some relevant screenshots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a screenshot posted by @jonatack here:
#534 (review)
But this style is already used in sendcoinsdialog.ui and sendcoinsdialog.cpp for invalid custom change addresses and insufficient funds , so it seems to be a well tested configuration.
jonatack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Jon Atack <[email protected]>
48bd233 to
dd8bd45
Compare
|
A constant message seems as useless as the red background colour. Concept NACK |
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
1 similar comment
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
|
Closing due to lack of interest. |

This PR is an alternative to #533 that addresses #533 (review) .
While this PR no longer provides a detailed error message, it still brings some UI improvements:
. Improve user experience by showing an error message instead of just changing the color of
QLineEdit. Currently, when an invalid address is entered in
custom change address, an error message is displayed. But the same does not happen in thePay Tofield or when adding a new address in the address manager. This PR standardizes error handling for all address fields.. The message added in this PR is the same as used in the
custom change address, which is already translated into several languages.