Introduce Create Single-Sig wallet flow #403

johnny9 · 2024-05-28T03:33:08Z

These changes add more pages after the initial onboarding.

To test, run the application with the -resetguisettings option.

Link to github actions build artifacts.

This allows components using the ContinueButton to apply their own color variations.

MarnixCroes

every entrybox should automatically be selected, so user doesn't have to move the cursor there and click it to enter something
at Create password, good to give feedback when user can't continue because passwords don't match
CreateConfirm dialog shouldn't have a back button imo, the wallet is already created so going back doesn't make sense, same for CreateBackup

some other things, but maybe for a follow-up:

check and don't allow to enter an already existing wallet name
at every entry it is intuitive to press enter to trigger the continue button, maybe good time to introduce the behavior that enter keystroke triggers it
the transition to the wallet home page after clicking done at CreateConfirm is in the opposite direction of the rest of the create wallet flow, why?

MarnixCroes · 2024-05-28T08:18:35Z

src/qml/pages/wallet/CreateIntro.qml

+        CoreText {
+            Layout.topMargin: 25
+            Layout.alignment: Qt.AlignCenter
+            text: qsTr("You are about to create \na single-key bitcoin wallet")


Suggested change

text: qsTr("You are about to create \na single-key bitcoin wallet")

text: qsTr("You are about to create \na single-sig bitcoin wallet")

It says "single-key" also in figma.

yeah, "single-key" is wrong and also confusing imo

I concur "single-sig" is more intuitive than "single-key". It seems "single-key" is referenced in the docs although most people/users only refer to "single-sig"

We generally use multi-key in the design community (example). Some reasons:

"sig" is an abbreviation that many people may not be familiar with

Avoiding "signature" altogether in the applications removes another technical concept that people don't really need to be aware of. For example, "sign transaction" can be just be the more common term "approve transaction". Just part of the overall idea to use fewer technical terms if possible

If we want to be super specific in technical terms, then a "single-sig" wallet could even be a "multi-key" wallet. For example, in a wallet with 3 keys that only requires 1 signature

I understand that the technical terms can be more intuitive for us who are super deep into the tech, and they allow us to discuss things more precisely. For broader audiences, especially global ones where english may be the second language, it's often best to simplify things a little (you even have tools for that like Hemingway). Does that sound reasonable?

pablomartin4btc

tACK 4c047e0

It creates the wallet successfully, with or without password (skip it when it's offered).

I agree with all observations from @MarnixCroes as, tested on desktop platform, I experienced the same issues.

some other things, but maybe for a follow-up:
* check and don't allow to enter an already existing wallet name

This is what I first tested, when user enters the same wallet name doesn't do anything/ warn about the situation (doesn't override existent ones at least 🙏🏼) and it goes to the CreateConfirm saying it was created.

* the transition to the wallet home page after clicking done at CreateConfirm is in the opposite direction of the rest of the create wallet flow, why?

I'd say opposite direction to the rest of the onboarding flow even, so create wallet flow follows the same pattern (screen passed to the left as we move forward to the next form/ screen to the right) until the user clicks on "Done" or even if the user "skip"s the wallet creation. Unless it's intentional, it seems there's an inconsistency here.

On CreateBackup.qml, there's a "View file" button (that's doesn't work yet?), is this the backup feature? If so I see in figma says "Save wallet file" on that button, otherwise other than "CreateBackup" I'd name the .qml file as "BackupIntro" o "BackupWarning"/ Info.

I see other discrepancies (missing options/ different wording) against figma, is this intentional?

pablomartin4btc · 2024-05-29T10:29:12Z

src/qml/pages/wallet/CreateIntro.qml

+        CoreText {
+            Layout.topMargin: 25
+            Layout.alignment: Qt.AlignCenter
+            text: qsTr("You are about to create \na single-key bitcoin wallet")


It says "single-key" also in figma.

D33r-Gee

tACK 4c047e0 on WSL Ubuntu 22.04.

Wallet creation worked. In general agree with Marnix's comments.

And to be clear is this the first iteration, then layering more functionality (i.e. error messages, wallet name collision and more specific passwords hints )?

johnny9 · 2024-05-31T01:35:21Z

tACK 4c047e0 on WSL Ubuntu 22.04.

Wallet creation worked. In general agree with Marnix's comments.

And to be clear is this the first iteration, then layering more functionality (i.e. error messages, wallet name collision and more specific passwords hints )?

Yeah this is just following what was ready in the Figma. I think building it helps identify all of the gaps. I think all of these comments are great and I'll do my best to get these in on this first change-set.

hebasto · 2024-06-08T08:10:56Z

src/qt/bitcoin.cpp

-    qInstallMessageHandler(DebugMessageHandler);
+    //qInstallMessageHandler(DebugMessageHandler);


Why is that commented out?

hebasto · 2024-06-08T08:11:15Z

cc @GBKS

stackingsaunter · 2024-06-26T13:01:06Z

Testing the PR, so far worked well and created a wallet. "View file" button didn't work at all though.

I see other discrepancies (missing options/ different wording) against figma, is this intentional?

Yeah this is just following what was ready in the Figma. I think building it helps identify all of the gaps. I think all of these comments are great and I'll do my best to get these in on this first change-set.

@johnny9 mentioned in the issue in design repo, the lastest Figma design is here and was not yet merged to main Figma file.

It does not differ greatly from what's in this PR. Minor changes were introduced from user testing the flow. All differences should be highlighterd in the file and issue

D33r-Gee · 2024-07-31T15:52:29Z

tACK a3de255 on WSL Ubuntu 22.04

Works as expected, was able to create a new wallet in the default datadir

…lly selected 0beac80 qml: create wallet: set focus on TextField (Marnix) Pull request description: add `focus: true` to make it automatically selected so user doesn't have to first manually select it before it can type something addresses #403 (review) ACKs for top commit: johnny9: tACK 0beac80 Tree-SHA512: 61430831010dbd582176e9fd57ec7dcafbc5c705ee7ede7d7d33bc5d49e76340d4d233de385f2b59fc8c27d4422d3d82c30238678a5ee1429f7659800e6820b0

456d28a qml: uncomment DebugMessageHandler install (johnny9) Pull request description: DebugMessageHandler is needed to route output to debug.log and should not have been commented out. Mistakenly commented out in #403 ACKs for top commit: MarnixCroes: ACK 456d28a hebasto: ACK 456d28a Tree-SHA512: c78e526deccba366854287c796e2ac4843f1aba7b936d6955b6ec2212e75fac6a4372e3994e4045a45e083c7422fb827fddb674c64a593affa1226589f14d8ab

johnny9 added 3 commits May 27, 2024 17:59

qml: Add color properties to ContinueButton

4f11e01

This allows components using the ContinueButton to apply their own color variations.

qml: Add DISABLED state to ContinueButton

931d442

qml: Introduce AddWallet page after onboarding

0266742

johnny9 force-pushed the create-wallet-pr branch 3 times, most recently from fb61899 to 4c047e0 Compare May 28, 2024 04:00

MarnixCroes reviewed May 28, 2024

View reviewed changes

pablomartin4btc reviewed May 29, 2024

View reviewed changes

D33r-Gee reviewed May 29, 2024

View reviewed changes

hebasto reviewed Jun 8, 2024

View reviewed changes

qml: Introduce Create Wallet Single-Sig flow

a3de255

johnny9 force-pushed the create-wallet-pr branch from 4c047e0 to a3de255 Compare July 27, 2024 04:23

hebasto merged commit a73577b into bitcoin-core:main Aug 1, 2024
9 checks passed

This was referenced Aug 5, 2024

create wallet: set focus on TextField so it is automatically selected #410

Merged

create wallet: remove back navigation from CreateConfirm and CreateBackup #412

Open

create wallet: don't allow entry of already existing wallet name #413

Open

johnny9 mentioned this pull request Aug 9, 2024

Uncomment DebugMessageHandler install #414

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce Create Single-Sig wallet flow #403

Introduce Create Single-Sig wallet flow #403

johnny9 commented May 28, 2024 •

edited

Loading

MarnixCroes left a comment

MarnixCroes May 28, 2024

pablomartin4btc May 29, 2024

MarnixCroes May 29, 2024

D33r-Gee May 29, 2024

GBKS Jun 20, 2024

pablomartin4btc left a comment

pablomartin4btc May 29, 2024

D33r-Gee left a comment

johnny9 commented May 31, 2024

hebasto Jun 8, 2024

hebasto commented Jun 8, 2024

stackingsaunter commented Jun 26, 2024 •

edited

Loading

D33r-Gee commented Jul 31, 2024

	text: qsTr("You are about to create \na single-key bitcoin wallet")
	text: qsTr("You are about to create \na single-sig bitcoin wallet")

		qInstallMessageHandler(DebugMessageHandler);
		//qInstallMessageHandler(DebugMessageHandler);

Introduce Create Single-Sig wallet flow #403

Introduce Create Single-Sig wallet flow #403

Conversation

johnny9 commented May 28, 2024 • edited Loading

MarnixCroes left a comment

Choose a reason for hiding this comment

MarnixCroes May 28, 2024

Choose a reason for hiding this comment

pablomartin4btc May 29, 2024

Choose a reason for hiding this comment

MarnixCroes May 29, 2024

Choose a reason for hiding this comment

D33r-Gee May 29, 2024

Choose a reason for hiding this comment

GBKS Jun 20, 2024

Choose a reason for hiding this comment

pablomartin4btc left a comment

Choose a reason for hiding this comment

pablomartin4btc May 29, 2024

Choose a reason for hiding this comment

D33r-Gee left a comment

Choose a reason for hiding this comment

johnny9 commented May 31, 2024

hebasto Jun 8, 2024

Choose a reason for hiding this comment

hebasto commented Jun 8, 2024

stackingsaunter commented Jun 26, 2024 • edited Loading

D33r-Gee commented Jul 31, 2024

johnny9 commented May 28, 2024 •

edited

Loading

stackingsaunter commented Jun 26, 2024 •

edited

Loading