Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Sep 13, 2021

I hope the site can cope with the new version syntax.

@harding
Copy link
Contributor

harding commented Sep 13, 2021

Ran tests on 10498a7 manually, they all pass:

harding@devbcco:~/bitcoincore.org$ make
bundle exec jekyll clean
Configuration file: /home/harding/bitcoincore.org/_config.yml
           Cleaner: Removing /home/harding/bitcoincore.org/_site...
           Cleaner: Removing /home/harding/bitcoincore.org/.jekyll-metadata...
           Cleaner: Removing .sass-cache...
bundle exec jekyll build --future --drafts --unpublished
Configuration file: /home/harding/bitcoincore.org/_config.yml
            Source: /home/harding/bitcoincore.org
       Destination: /home/harding/bitcoincore.org/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
                    done in 67.922 seconds.
 Auto-regeneration: disabled. Use --watch to enable.
## Check for broken Markdown reference-style links that are displayed in text unchanged, e.g. [broken][broken link]
! find _site/ -name '*.html' | xargs grep ']\[' | grep -v skip-test | grep .
## Check for malformed HTML and broken internal links
bash -c "set -o pipefail ; bundle exec htmlproofer --check-html --disable-external --url-ignore '/^\/bin/.*/' ./_site | cat"
Running ["ImageCheck", "ScriptCheck", "HtmlCheck", "LinkCheck"] on ["./_site"] on *.html... 


Ran on 1421 files!


HTML-Proofer finished successfully.
## Check that links on the /en/download page point to the separately-stored binaries in /bin
contrib/qa/test-binary-availability.sh && echo "SUCCESS checking URLs for binaries"
SUCCESS checking URLs for binaries

harding@devbcco:~/bitcoincore.org$ git log -1 --oneline
10498a7 Release 22.0: fixups

@harding
Copy link
Contributor

harding commented Sep 13, 2021

Quickly previewed the site on 10498a7 . Home page, release blog post, and release notes all LGTM. I'm not able to test the download links on a local preview (since I don't have the binaries here), but the test for broken binary links is passing, so it should be ok.

@harding
Copy link
Contributor

harding commented Sep 13, 2021

Whoops, force pushed to trim some excessive copy/paste detail from a previous release.

@laanwj laanwj merged commit 4ed9e64 into master Sep 13, 2021
@fanquake fanquake mentioned this pull request Sep 29, 2021
harding added a commit that referenced this pull request Oct 4, 2021
a282080 Bitcoin Core 0.21.2 (fanquake)

Pull request description:

  Adds a release announcement for 0.21.2. Modeled after #792.

ACKs for top commit:
  harding:
    Tested ACK a282080 .  Checked local preview and locally ran the CI tests.  Thanks!

Tree-SHA512: d27641dda209225d043adfa86a1f99e58ab1f4164e8b18e65cefda5da52ecb3ddb812cabdab7ca36de83b68520d2c387b15ac11a9ee610055211587680e27e85
@laanwj laanwj deleted the bitcoin-core-22.0 branch October 11, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants