Sprint 4: Basket Page, Catalog Page Enhancements, and About Us Page Implementation #50

bitbybit · 2025-06-16T06:58:43Z

Task: https://github.com/rolling-scopes-school/tasks/blob/master/tasks/eCommerce-Application/Sprints/Sprint%234.md
Deploy: https://release-basket-about-us.js-fe-2024q4.pages.dev/
Done: 16.06.2025 / deadline: 17.06.2025
Score: 60 / 60

1. Code Review Participation (10 points): Students actively participate in code reviews, providing constructive feedback and suggestions to their peers.
2. No Merges Without Approvals (10 points): Pull requests are not merged without approvals from other team members, ensuring the quality of code contributions.
3. Pull Request Descriptions (10 points): Pull requests include detailed descriptions, outlining the changes made and the purpose of the changes, facilitating better understanding and review.
4. Task Board Management (10 points): Students maintain and regularly update a task board (e.g., Trello, Jira), ensuring that tasks are moved according to their progress and completion.
5. Active Participation in Development Discussions (5 points): Students take an active role in discussing the development process, sharing ideas, and collaborating on solutions and improvements.
6. Unit Test Coverage (15 points): The codebase has a minimum of 30% unit test coverage, ensuring the reliability and robustness of the implemented features.

Bumps the npm_and_yarn group with 1 update in the / directory: [brace-expansion](https://github.com/juliangruber/brace-expansion). Updates `brace-expansion` from 1.1.11 to 1.1.12 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]>

…yarn-6ea9762674 build(deps): Bump brace-expansion from 1.1.11 to 1.1.12 in the npm_and_yarn group across 1 directory

feat: ECOM-80 add pagination to catalog page

ECOM-79 Integrate Catalog Page with Commercetools API; ECOM-95 Routing to Basket Page

feat: ECOM-88 add message when cart is empty

…/fe-ecommerce into feature/ECOM-91

feat: ECOM-90 add clear shopping cart button

feat: ECOM-85 add product item quantity control

ECOM-84 Fetch and Display Cart Items

…/fe-ecommerce into feature/ECOM-91

ECOM-89 Apply Promo Code and Display Updated Prices

Added About Us page, add/remove item on product page

ECOM-96 add Quantity Indicator to header

…/fe-ecommerce into feature/ECOM-91

Change color theme and fix discount layout

refactor: ECOM-89 add some styles to discount card

fix: ECOM-83 cart item info flex box, Discounts header

Fix Breadcrumbs test

Code style PR updates

test: ECOM-83 add cart item view, empty cart, quantity control tests

test: ECOM-83 fix empty cart test

Crosscheck fixes

YuliyaMinsk

Great job overall! The structure is clean, the typing is thoughtful, and it's clear you're paying attention to error handling and async flow. Just a few tweaks and it'll be even more maintainable. Keep up the good work)

app/api/client.ts

app/components/ui/AlertDialog.tsx

app/components/ui/Sidebar.tsx

app/layouts/components/Navigation.tsx

YuliyaMinsk · 2025-06-22T18:00:56Z

app/pages/product/ProductDetail/CartToggleButton.tsx

+  const handleClick = async (event: MouseEvent<HTMLButtonElement>): Promise<void> => {
+    event.stopPropagation()
+    setIsLoading(true)
+    setError(undefined)
+    try {
+      if (isInCart) {
+        await dispatch(removeProduct({ productId: product.id, quantity: 1 })).unwrap()
+        toast('❌ Removed from Cart')
+      } else {
+        await dispatch(addProduct({ productId: product.id, quantity: 1 })).unwrap()
+        toast('🛒 Added to Cart')
+      }
+    } catch (error) {
+      setError('An error occurred. Please try again.')
+      toast(error instanceof Error ? error.message : '❌ Failed to update the cart')
+    } finally {
+      setIsLoading(false)
+    }
+  }


Just a heads-up: since handleClick is async, setIsLoading(false) might run after the component unmounts, which can trigger a React warning. To avoid that, it's a good idea to track if the component is still mounted before updating state

@YuliyaMinsk it seems that the warning and this recommendation is gone since React 18 release: facebook/react#22114

app/pages/product/hooks/useProductInfo.tsx

app/pages/profile/UserDetail/UserDetailEdit/UseAddressForm/UserAddressFormBody.tsx

app/pages/profile/UserDetail/UserDetailView/UserAddress.tsx

bitbybit · 2025-06-22T22:48:37Z

@YuliyaMinsk #65

merucoding and others added 30 commits June 11, 2025 19:32

feat: ECOM-80 add pagination to catalog page

1e136d3

fix: ECOM-80 reset to first page when searching

422e085

Merge pull request #42 from bitbybit/dependabot/npm_and_yarn/npm_and_…

be06e90

…yarn-6ea9762674 build(deps): Bump brace-expansion from 1.1.11 to 1.1.12 in the npm_and_yarn group across 1 directory

feat: ECOM-78 add disabled state to add to cart button

e4a473d

refactor: ECOM-77 resolve PR comments

09ea2fa

Merge pull request #41 from bitbybit/feature/ECOM-77

7d90aa8

feat: ECOM-80 add pagination to catalog page

feat: ECOM-91 add about us page

d18f067

feat: ECOM-79 cart api

dcbfd58

Merge pull request #43 from bitbybit/feature/ECOM-79

ef3e0e5

ECOM-79 Integrate Catalog Page with Commercetools API; ECOM-95 Routing to Basket Page

feat: ECOM-88 add message when cart is empty

84698b8

Merge pull request #44 from bitbybit/feature/ECOM-77

985543f

feat: ECOM-88 add message when cart is empty

refactor: ECOM-84 rename ITEMS_PER_PAGE

3ebee9a

feat: ECOM-90 add clear shopping cart button

2c2a08f

fix: ECOM-91 fix swiper styles

989cbb8

Merge branch 'release/basket-about_us' of https://github.com/bitbybit…

75ddcec

…/fe-ecommerce into feature/ECOM-91

Merge pull request #45 from bitbybit/feature/ECOM-77

1471b08

feat: ECOM-90 add clear shopping cart button

feat: ECOM-85 add product item quantity control

a6be736

feat: ECOM-91 fix swiper

f1f82c1

feat: ECOM-84 cart store

36ffc1e

Merge pull request #46 from bitbybit/feature/ECOM-77

4d6cfa6

feat: ECOM-85 add product item quantity control

Merge pull request #47 from bitbybit/feature/ECOM-84

221ac89

ECOM-84 Fetch and Display Cart Items

Merge branch 'release/basket-about_us' of https://github.com/bitbybit…

2084400

…/fe-ecommerce into feature/ECOM-91

feat: ECOM-91 add remove/add button to product page

c91cbb6

feat: ECOM-89 discount codes

08d57df

fix: ECOM-91 fix images, separate files

3146248

Merge pull request #49 from bitbybit/feature/ECOM-89

6de07be

ECOM-89 Apply Promo Code and Display Updated Prices

feat: ECOM-83 add cart item view, delete cart item button

23873bc

fix: ECOM-91 fix name of file

5fe1144

Merge pull request #48 from bitbybit/feature/ECOM-91

ad0c549

Added About Us page, add/remove item on product page

zhuravel17 and others added 7 commits June 17, 2025 00:03

refactor: ECOM-91 change color theme in notFound files

804eb17

Merge pull request #53 from bitbybit/feature/ECOM-91

edeb263

ECOM-96 add Quantity Indicator to header

Merge branch 'release/basket-about_us' of https://github.com/bitbybit…

a36d898

…/fe-ecommerce into feature/ECOM-91

fix: ECOM-91 fix discounts layout

e0f2e65

Merge pull request #55 from bitbybit/feature/ECOM-91

fd8f115

Change color theme and fix discount layout

refactor: ECOM-89 add some styles to discount card

c77242c

Merge pull request #56 from bitbybit/feature/ECOM-77

af514b1

refactor: ECOM-89 add some styles to discount card

bitbybit marked this pull request as ready for review June 16, 2025 22:13

merucoding changed the title ~~Sprint 4~~ Sprint 4: Basket Page, Catalog Page Enhancements, and About Us Page Implementation Jun 17, 2025

merucoding and others added 6 commits June 17, 2025 15:41

fix: ECOM-83 cart item info flex box, Discounts header

bc6480d

Merge pull request #57 from bitbybit/fix/ECOM-83

f908707

fix: ECOM-83 cart item info flex box, Discounts header

refactor: ECOM-83 code style PR updates

d89ff34

fix: fix test

5e3d53a

Merge pull request #59 from bitbybit/fix-test

88ada10

Fix Breadcrumbs test

Merge pull request #58 from bitbybit/pr-fixes

b9e928c

Code style PR updates

bitbybit requested review from merucoding and zhuravel17 June 17, 2025 15:10

zhuravel17 approved these changes Jun 17, 2025

View reviewed changes

test: ECOM-83 add cart item view, empty cart, quantity control tests

c85601f

merucoding approved these changes Jun 17, 2025

View reviewed changes

bitbybit and others added 5 commits June 17, 2025 20:27

Merge pull request #60 from bitbybit/test/ECOM-83

6120099

test: ECOM-83 add cart item view, empty cart, quantity control tests

test: ECOM-83 fix empty cart test

d185efe

Merge pull request #61 from bitbybit/test/ECOM-83

1d5c509

test: ECOM-83 fix empty cart test

fix: ECOM-83 crosscheck fixes

2221631

Merge pull request #62 from bitbybit/crosscheck-fixes

2c8bb5a

Crosscheck fixes

bitbybit merged commit d972255 into develop Jun 20, 2025
1 check passed

YuliyaMinsk reviewed Jun 22, 2025

View reviewed changes

bitbybit mentioned this pull request Jun 22, 2025

PR fixes #65

Merged

bitbybit deleted the release/basket-about_us branch June 23, 2025 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sprint 4: Basket Page, Catalog Page Enhancements, and About Us Page Implementation #50

Sprint 4: Basket Page, Catalog Page Enhancements, and About Us Page Implementation #50

Uh oh!

bitbybit commented Jun 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

YuliyaMinsk left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YuliyaMinsk Jun 22, 2025

Uh oh!

bitbybit Jun 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bitbybit commented Jun 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Sprint 4: Basket Page, Catalog Page Enhancements, and About Us Page Implementation #50

Sprint 4: Basket Page, Catalog Page Enhancements, and About Us Page Implementation #50

Uh oh!

Conversation

bitbybit commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

YuliyaMinsk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YuliyaMinsk Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

bitbybit Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bitbybit commented Jun 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bitbybit commented Jun 16, 2025 •

edited

Loading