feat(vllm): complete Prime RL protocol integration - #4
Draft
biswapanda wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base and relationship to earlier work
This PR is intentionally based on
acc5ee96e39c4c84506f87aa2fd15589682deb4e, the exact head of ai-dynamo#13066 used for end-to-end validation. It is a fresh review delta in this fork and does not update or reuse #3.The multimodal routing design selectively reuses the generic capability and routing contracts from ai-dynamo#11588 and ai-dynamo#11532 while retaining the newer native sidecar implementation from ai-dynamo#13066.
Impact
Prime-RL can discover and control a stable Dynamo worker cohort, generate through aggregated or prefill/decode deployments, update independently deployed vLLM-RS workers, and train with multimodal or routed-experts data while the ordinary Dynamo paths remain unchanged unless the new fields and routes are used.
Validation
cargo fmt --all -- --checkcargo test -p dynamo-vllm-sidecar(33 unit tests plus the executable doctest)cargo test -p dynamo-llm protocols::openai::generate(28 tests)cargo test -p dynamo-kv-router mm_identifier_hash_preserves_vllm_and_opaque_identifiersQwen/Qwen3-VL-4B-Instructmultimodal training and post-update generation