handle changed return code in libnl 3.12 #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With libnl 3.12 the return code for -EHOSTUNREACH changed from -NLE_FAILURE to -NLE_HOSTUNREACH. This causes our code to assume something fatal broke, and terminate on unreachable: baseboxd[1756]: F20251206 09:08:38.378911 1935 nl_route_query.h:95] query_route:%sHost is unreachable baseboxd[1756]: *** Check failure stack trace: *** baseboxd[1756]: @ 0x7fc6c510604d google::LogMessage::Fail() baseboxd[1756]: @ 0x7fc6c51085c6 google::LogMessage::SendToLog() baseboxd[1756]: @ 0x7fc6c5105b8a google::LogMessage::Flush() baseboxd[1756]: @ 0x7fc6c5108c39 google::LogMessageFatal::~LogMessageFatal() baseboxd[1756]: @ 0x55d9501e117e (unknown) baseboxd[1756]: @ 0x55d9501df17f (unknown) baseboxd[1756]: @ 0x55d9501ba68b (unknown) baseboxd[1756]: @ 0x7fc6c45b9083 rofl::cthread::handle_wakeup() baseboxd[1756]: @ 0x7fc6c45b9718 rofl::cthread::run_loop() baseboxd[1756]: @ 0x7fc6c3b8f5ea (unknown) baseboxd[1756]: @ 0x7fc6c3c11300 (unknown) Fix this by checking for -NLE_HOSTUNREACH as well, and add a define in case we build against older libnl versions. We still have to check for -NLE_FAILURE anyway. Signed-off-by: Jonas Gorski <[email protected]>
rubensfig
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With libnl 3.12 the return code for
-EHOSTUNREACHchanged from-NLE_FAILUREto-NLE_HOSTUNREACH. This causes our code to assume something fatal broke, and terminate on unreachable:Fix this by checking for
-NLE_HOSTUNREACHas well, and add a define in case we build against older libnl versions.We still have to check for
-NLE_FAILUREanyway.Description
Motivation and Context
How Has This Been Tested?