feature: pickFile() is now implemented for windows
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pcprinz , first of all — thanks for your PRs! Just for you information, the TS code update you did in this PR breaks New Arch / Codegen, at least for Android-builds, because it No worries, though, I fixed it (4720052). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pickFile()now opens the native windows file picker.But the
optionsdiffer from the existing options for the other platforms, since the windows file picker works different. The native Filepicker doesn't support MIME types but therfore filters thefileExtensions. Additionally theoptionsalso allow to set apickerType, so the user can actually picksingeFiles,multipleFilesas well as afolder.Everything is tested with the example app. No breaking changes for the other pickers