Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows issues #87

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Fix windows issues #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec5269f
fix: allow unicode paths for all relevant methods
pcprinz Nov 23, 2024
f443eb4
fix: write() creates non existing files on windows also
pcprinz Nov 24, 2024
e8df1b2
fix: adjusted method documentation for windows compatibility
pcprinz Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ and [old][Old Architecture] [RN][React Native] architectures.
thumbnails.
- [copyAssetsVideoIOS()] — Copies a video from the assets-library
to the specified destination.
- [copyFile()] — Copies a file to a new destination.
- [copyFile()] — Copies a file (or a folder with files - except on Android/Windows) to a new destination.
- [copyFileAssets()] — (Android only) Copies Android app's asset(s)
to the specified destination.
- [copyFileRes()] — (Android only) Copies specified resource to
Expand All @@ -96,7 +96,7 @@ and [old][Old Architecture] [RN][React Native] architectures.
- [getFSInfo()] — Gets info on the free and total storage space
on the device, and its external storage.
- [mkdir()] — Creates folder(s) at the given path.
- [moveFile()] — Moves a file (or a folder with files) to a new location.
- [moveFile()] — Moves a file (or a folder with files - except on Windows) to a new location.
- [pathForGroup()] — (iOS only) Returns the absolute path to
the directory shared for all applications with the same security group
identifier.
Expand Down Expand Up @@ -626,7 +626,7 @@ Copies a file to a new destination. Throws if called on a directory.
already exists. On iOS an error will be thrown if the file already exists.
— **beware**, this has not been verified yet.

**BEWARE:** On Android [copyFile()] throws if called on a folder; on other
**BEWARE:** On Android and Windows [copyFile()] throws if called on a folder; on other
platforms it does not throw, but it has not been verified yet, if it actually
copies a folder with all its content there.

Expand Down Expand Up @@ -1174,9 +1174,7 @@ in this library fork.
```ts
function write(filepath: string, contents: string, position?: number, encoding?: EncodingT): Promise<void>;
```
**VERIFIED:** Android, iOS, macOS, Windows \
**BEWARE:** On Windows it seems to work differently from other platforms,
throwing if attempting to write to a non-existing file.
**VERIFIED:** Android, iOS, macOS, Windows

Writes content to a file at the given random access position.

Expand Down
Loading