Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] readDir() and probably other methods don't handle special characters in directory paths #82

Closed
AchillesChristianPrinz opened this issue Nov 10, 2024 · 0 comments
Labels
P1 High priority issue. Ready Ready for release. Windows

Comments

@AchillesChristianPrinz
Copy link

The readDir method in ReactNativeModule.cpp does not correctly handle directory paths that contain special characters such as ö, ä, ü. This causes the method to fail when attempting to read directories with such characters in their paths.

winrt::fire_and_forget ReactNativeModule::readDir(std::string directory, ReactPromise<JSValueArray> promise) noexcept

Suggested fix

Ensure that the methods correctly handle special characters by using std::wstring for directory paths and making necessary adjustments to the method calls.

@AchillesChristianPrinz AchillesChristianPrinz changed the title readDir and probably other methods don't handle special characters in directory paths readDir and probably other methods don't handle special characters in directory paths Nov 10, 2024
@AchillesChristianPrinz AchillesChristianPrinz changed the title readDir and probably other methods don't handle special characters in directory paths readDir() and probably other methods don't handle special characters in directory paths Nov 10, 2024
@birdofpreyru birdofpreyru added the P1 High priority issue. label Nov 10, 2024
@birdofpreyru birdofpreyru added the In Progress Work in progress. label Nov 12, 2024
@birdofpreyru birdofpreyru changed the title readDir() and probably other methods don't handle special characters in directory paths [Windows] readDir() and probably other methods don't handle special characters in directory paths Nov 16, 2024
@birdofpreyru birdofpreyru added On Hold Blocked for some reason. and removed In Progress Work in progress. labels Nov 16, 2024
@birdofpreyru birdofpreyru added In Progress Work in progress. Ready Ready for release. and removed On Hold Blocked for some reason. In Progress Work in progress. labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue. Ready Ready for release. Windows
Projects
None yet
Development

No branches or pull requests

2 participants