Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type interface differences from react-native-fs undocumented #36

Closed
angusryer opened this issue Apr 13, 2024 · 1 comment
Closed

Type interface differences from react-native-fs undocumented #36

angusryer opened this issue Apr 13, 2024 · 1 comment
Labels
P3 Small issue. Ready Ready for release.

Comments

@angusryer
Copy link

Hi! Thanks for continuing to maintain this lib!

During a migration to your library (due to the new-ish Apple Privacy requirements), I noticed that the ReadDirItem type from itinance/react-native-fs is not present in this lib. It seems to have been changed to ReadDirResItemT.

So the statement in the readme, aside from the word "presumably", is not totally correct:

v2.22.0 of this library is, presumably, a drop-in replacement for the latest (v2.20.0) release of the original, upstream react-native-fs (beside the need to upgrade host project to the lates RN v0.73). It has matching functionality and API, with just a handfull of internal fixes, and a few additions.

I suppose it should be documented (along with other changes) for those migrating over. Not sure if any other interfaces have also changed.

@birdofpreyru birdofpreyru added the P3 Small issue. label Apr 13, 2024
@birdofpreyru
Copy link
Owner

Yes, I did append T to all type names. Sorry for not mentioning it in the README section you pointed to. I'll add it later.

birdofpreyru added a commit that referenced this issue Apr 14, 2024
@birdofpreyru birdofpreyru added the Ready Ready for release. label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Small issue. Ready Ready for release.
Projects
None yet
Development

No branches or pull requests

2 participants