Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download Progress Callback does not get called on android #31

Closed
jobpaardekooper opened this issue Mar 23, 2024 · 1 comment
Closed

Download Progress Callback does not get called on android #31

jobpaardekooper opened this issue Mar 23, 2024 · 1 comment
Labels
P2 Important issue. Ready Ready for release.

Comments

@jobpaardekooper
Copy link

I recently moved over from the original RNFS to this library.

I am using the progress option on the downloadFile method to get DownloadProgressCallbackResultT . This was working properly before I migrated to this library. Now that I have made the switch it seems to only be working on iOS. On Android the callback never fires but the file downloads successfully.
@birdofpreyru birdofpreyru added the P2 Important issue. label Mar 26, 2024
birdofpreyru added a commit that referenced this issue Mar 26, 2024
@birdofpreyru
[#31] Android: downloadFile() - fixes download progress callback
c4550f6 
Note: It has been broken in the release v2.22.0-alpha.1, during Java >
Kotlin migration of Android implementation, due to a wrong method
signature turning an override method of extended class into just a
method which is never called.
@birdofpreyru birdofpreyru added Ready Ready for release. In Progress Work in progress. and removed Ready Ready for release. labels Mar 26, 2024
@birdofpreyru
Copy link
Owner

Does not seem to work on iOS (new arch) either

birdofpreyru added a commit that referenced this issue Mar 26, 2024
@birdofpreyru
[#31] iOS: downloadFile() - fix: progress callback should be called n…
7409907 
…o matter whether there is begin callback set or not
@birdofpreyru birdofpreyru added Ready Ready for release. and removed In Progress Work in progress. labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Important issue. Ready Ready for release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@birdofpreyru @jobpaardekooper