Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: pickFile() should be patched for the case when selection is cancelled, and thus messages a null URI #15

Closed
birdofpreyru opened this issue Oct 12, 2023 · 0 comments
Labels
P3 Small issue. Ready Ready for release.

Comments

@birdofpreyru
Copy link
Owner

public void onActivityResult(Uri uri) {
WritableArray res = Arguments.createArray();
res.pushString(uri.toString());
pendingPickFilePromises.pop().resolve(res);
}

☝️ Here, we should guard against uri being null.

@birdofpreyru birdofpreyru added the P3 Small issue. label Oct 12, 2023
@birdofpreyru birdofpreyru changed the title Android: pickFile() should be patched for the case when selection is cancelled, and thus messages a _null_ URI Android: pickFile() should be patched for the case when selection is cancelled, and thus messages a null URI Oct 12, 2023
@birdofpreyru birdofpreyru added the Ready Ready for release. label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Small issue. Ready Ready for release.
Projects
None yet
Development

No branches or pull requests

1 participant