-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiff converter returns DataArray instead of Dataset. #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this change break support for multi-band GeoTIFFs? Is there a way to add a test for this here?
Good point, do you have a multiband geotiff laying around ? |
Found one, and what happens is that bands are just a dimension of the DataArray. |
Ah, if that's the case, I'm relatively comfortable with this change. This behaviour has been around for a year, though, so it's possible that people are using. Would it be too cautious to ask for a second reviewer on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for me, but let's wait for @cehbrecht before moving forward.
No, it's been merged last March, see https://github.com/bird-house/birdy/pull/240/files |
OK, if it was introduced two months ago (0.8.5), then it's clearly a regression. No need for Carsten to weigh in. |
@huard If you want to prepare a version release, I'll sign off on it. |
Overview
This PR fixes #247
Changes:
Related Issue / Discussion
Additional Information
Links to other issues or sources.