Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix breakage with owslib 0.29 removal of verbose argument #217

Merged
merged 9 commits into from
Apr 28, 2023
Merged

Conversation

huard
Copy link
Contributor

@huard huard commented Apr 27, 2023

Overview

This PR fixes #216

Changes:

  • Added special case handling for verbose argument and raise DeprecationWarning

@huard huard requested review from cehbrecht and fmigneault April 27, 2023 13:05
birdy/client/base.py Outdated Show resolved Hide resolved
@cehbrecht
Copy link
Member

@huard looks good :) Thanks for the update.

You could change the workflow to use black with py38?

run: black --check --target-version py36 birdy tests

Not sure why build 3.6 is running and hanging ... it is not in the workflow ...

@huard huard merged commit 4cbd217 into master Apr 28, 2023
@Zeitsperre Zeitsperre deleted the fix-216 branch May 5, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

owslib removed verbose argument
3 participants