Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove gdal dependency checks. remove 52north tests #212

Merged
merged 1 commit into from
Apr 4, 2022
Merged

remove gdal dependency checks. remove 52north tests #212

merged 1 commit into from
Apr 4, 2022

Conversation

huard
Copy link
Contributor

@huard huard commented Feb 14, 2022

Overview

This PR fixes #211

Changes:

  • Removed gdal checks which fail even though gdal is installed...

@huard huard requested a review from cehbrecht February 14, 2022 21:03
@huard
Copy link
Contributor Author

huard commented Feb 14, 2022

@Zeitsperre FYI

Zeitsperre
Zeitsperre approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd thing about the error. Mind posting what the traceback for reference?

@huard
Copy link
Contributor Author

huard commented Feb 15, 2022

image

@huard
Copy link
Contributor Author

huard commented Feb 15, 2022

This happened on the "beta" PAVICS environment.

@tlvu
Copy link

tlvu commented Feb 15, 2022

This happened on the "beta" PAVICS environment.

For reproducibility, the current "beta" PAVICS Jupyter env is the docker image pavics/workflow-tests:220201. This beta image will change with time.

@tlvu
Copy link

tlvu commented Feb 15, 2022

This happened on the "beta" PAVICS environment.

For reproducibility, the current "beta" PAVICS Jupyter env is the docker image pavics/workflow-tests:220201. This beta image will change with time.

It has gdal=3.3.3=py38hcf2042a_0 conda package installed.

@cehbrecht
Copy link
Member

Would a "nogdal" solution make things better?
geopython/pywps#638

@Zeitsperre
Copy link
Contributor

@cehbrecht GDAL is baked into most of the tools that use birdy. The option would be nice for those few projects that don't use GDAL though!

@huard huard merged commit 0b56414 into master Apr 4, 2022
@huard huard deleted the fix-211 branch April 4, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

@cehbrecht cehbrecht cehbrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with gdal import in converter
4 participants
@huard @tlvu @cehbrecht @Zeitsperre