handle python keywords #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huard
approved these changes
Sep 10, 2019
|
Is this solution acceptable to the ophidia team ? |
@minomicetto Are you ok with this change? |
|
I am going to change the name of the parameter "return" to "return_code", independently from the bug, to better understand its meaning. So the solution is acceptable. |
|
@minomicetto @huard merged. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes #157. The
utils.sanitizemethod adds a trailing_to Python keywords to avoid the error in issue #157.Changes:
utils.sanitize.Related Issue / Discussion
#157
Additional Information
Using
keywordlist:https://www.programiz.com/python-programming/keyword-list