Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixingTheDocs #150

Merged
merged 8 commits into from
Aug 19, 2019
Merged

FixingTheDocs #150

merged 8 commits into from
Aug 19, 2019

Conversation

Zeitsperre
Copy link
Contributor

Overview

This PR fixes #147

Changes:

  • Added some mocked imports and configurations to sphinx conf.py
  • First pass at a .travis.yml update
  • Updated the ReadTheDocs.yml to employ version 2 of API

Related Issue / Discussion

Additional Information

Links to other issues or sources.

docs/source/conf.py Outdated Show resolved Hide resolved
@huard huard requested a review from cehbrecht August 19, 2019 18:18
Copy link

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Can show a RtD test build?

@Zeitsperre
Copy link
Contributor Author

@tlvu I can't seem to see any projects related to bird-house in RtD. It could be that I need to be added to the list of maintainers on that site.

@huard or @cehbrecht can you add me to the bird-house organization for RtD?

@huard
Copy link
Contributor

huard commented Aug 19, 2019

@Zeitsperre done for birdy. That's all I can do.

@Zeitsperre Zeitsperre self-assigned this Aug 19, 2019
@Zeitsperre Zeitsperre added this to the 0.7.0 milestone Aug 19, 2019
@Zeitsperre
Copy link
Contributor Author

Docs are now building and tests are passing on Travis. The setup for Travis isn't perfect but it works for now.

@Zeitsperre Zeitsperre requested a review from tlvu August 19, 2019 19:43
Copy link

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved earlier, looks good to me. How that you have access to birdy on RtD, you can have it build your branch you know ;)

@Zeitsperre Zeitsperre merged commit 9e9b39c into master Aug 19, 2019
@Zeitsperre Zeitsperre deleted the fix_147 branch August 19, 2019 20:51
@huard
Copy link
Contributor

huard commented Aug 19, 2019

@Zeitsperre In the future please wait for Carsten's approval before merging.

@Zeitsperre
Copy link
Contributor Author

Alright. Will do.

@cehbrecht
Copy link
Member

@Zeitsperre thanks for the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation build is broken on RTD
4 participants