-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AGRO-AGROVOC mappings #83
Conversation
CC @KrishnaTO The only thing I need to update is the ingestion pipeline for OWL since it doesn't currently accept AGRO's RDF/XML
A quick check shows good matches, wherever labels match or def exists. This is a great tool! Do you know if the AGROVOC synonyms are currently checked? Not to mention, our ontology also has lots of common labels as synonyms instead of the rdfs:labels. |
maybe it wasn't clear from the description but all of the labels/synonyms from AGRO are considered. Currently only the preferred labels from AGROVOC are considered. That could be updated if you think it's important. |
Got it, compared to the previous mappings, some terms have changed between either one of the sources. As well, AGROVOC seems to use "ENTRY TERMS" for synonyms (example), so there may be some mods there. But so happy with this tool, thanks @cthoyt ! |
@cthoyt How did you bypass the agro parsing error?
Note: I do have the dev versions of pyobo, pystow, and biomappings you updated. Did you mod pronto as well? |
@KrishnaTO I just went through PyStow and PyOBO to make sure there's a a PyPI release that's sufficient to make this work, so you can just get the new releases from |
It found the right path for AgrO after the mentioned reinstallations. |
@cthoyt Regarding the sanity check, AgrO has 1190 terms within its namespace (AGRO_), so 162 matches using label and synonyms (not sure if searches definitions?) isn't bad. The mentioned predictions were curated here with 142/162 positive exact matches. Let me know if want to merge and create a PR to this this branch. |
@KrishnaTO I'm sorry I missed your comment - it's great you triaged these! I will definitely merge them in a separate PR :) |
This PR adds predicted mappings between AGRO labels/synonyms and the English preferred terms from AGROVOC. The SPARQL query could be extended to use other alternative labels if desired.
@KrishnaTO can you do a sanity check - I'm surprised the number of suggestions is quite low