Added allocation-free correlation#39
Open
djohn134 wants to merge 2 commits intobionanoimaging:mainfrom
Open
Conversation
roflmaostc
reviewed
Nov 6, 2023
| end | ||
|
|
||
| function p_ccorr_aux(P, P_inv, u, v_ft) | ||
| return (P_inv.p * ((P * u) .* conj(v_ft) .* P_inv.scale)) |
Member
There was a problem hiding this comment.
please use conj.(v_ft). That should avoid some allocations.
Member
|
Thanks for adding this. We need to do a couple of things before we can merge :)
|
Member
|
@djohn134 are you still planning to merge your suggestions. It sounds like a good idea, but I agree with @roflmaostc that tests and docstrings would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
src/correlations.jlto include correlation plans and allocation-free correlations using buffers, similar to what was already present for convolutions insrc/convolutions.jl