Conversation
Fix note rendering for Playwright
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request modifies Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/content/docs/linter/domains.mdx (1)
393-394:⚠️ Potential issue | 🟡 MinorSame broken admonition syntax in Turborepo and Types domains — still not fixed.
The Turborepo (line 394) and Types (line 437) sections have the same malformed pattern this PR corrects for Playwright: the content, closing
:::, and a stray#character are all concatenated on one line (...rules.:::#). Aside blocks are indicated using a pair of triple colons:::to wrap content, so the closing marker must be on its own line; anything appended to it (like#) will break the block and produce garbled output.Since all three occurrences almost certainly share the same codegen defect, fixing the generator (see previous comment) should resolve all of them in one go.
Also applies to: 436-437
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/content/docs/linter/domains.mdx` around lines 393 - 394, The admonition blocks use a malformed closing marker (e.g., the opening ':::note[No recommended rules]' block currently ends with ':::#' on the same line as the content), which breaks the renderer; update the content for the Playwright, Turborepo and Types admonitions so the closing marker is on its own line (':::') and remove the stray '#' character, and if this is generated code, fix the generator that emits the admonition so it inserts a newline before the closing ':::' (identify the blocks by their opening token ':::note[No recommended rules]' and the problematic closing ':::#' to locate and correct them).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/content/docs/linter/domains.mdx`:
- Around line 70-72: The autogenerated domains.mdx is produced by the codegen
invoked by pnpm codegen:rules and the bug is that the generator emits a
single-line aside block instead of a proper Starlight aside with separate
opening, body, and closing lines; find the codegen function/template (e.g.,
generateDomainDoc, renderDomainSection, or emitAside/renderAside) that writes
the string ":::note[No recommended rules]" and change it to output three
separate lines: the opening ":::note[No recommended rules]" line, the content
line(s) (e.g., "Since all rules..."), and a closing ":::". Ensure the
template/renderer uses newline-terminated writes or joins lines with "\n" so the
closing ":::"
is on its own line when domains.mdx is generated.
---
Outside diff comments:
In `@src/content/docs/linter/domains.mdx`:
- Around line 393-394: The admonition blocks use a malformed closing marker
(e.g., the opening ':::note[No recommended rules]' block currently ends with
':::#' on the same line as the content), which breaks the renderer; update the
content for the Playwright, Turborepo and Types admonitions so the closing
marker is on its own line (':::') and remove the stray '#' character, and if
this is generated code, fix the generator that emits the admonition so it
inserts a newline before the closing ':::' (identify the blocks by their opening
token ':::note[No recommended rules]' and the problematic closing ':::#' to
locate and correct them).
Fix note rendering for Playwright, Turbo & Types
Summary
Before:

After:
