Skip to content

docs(linter): add Playwright domain documentation#3954

Merged
dyc3 merged 1 commit intobiomejs:mainfrom
abossenbroek:feat/playwright-domain-docs
Feb 16, 2026
Merged

docs(linter): add Playwright domain documentation#3954
dyc3 merged 1 commit intobiomejs:mainfrom
abossenbroek:feat/playwright-domain-docs

Conversation

@abossenbroek
Copy link
Contributor

Summary

  • Adds RuleDomain::Playwright match arm to codegen/src/domains.rs so the domains page includes a description for the new Playwright domain.

Companion to biomejs/biome#8960, which introduces 11 Playwright lint rules with a new RuleDomain::Playwright.

Note on CI

CI will fail until biomejs/biome#8960 is merged and the biome crate rev is bumped in this repo's Cargo.toml. This is expected per biomejs/biome#8960 (comment).

AI disclosure

This PR was authored with the assistance of Claude Code.

🤖 Generated with Claude Code

@netlify
Copy link

netlify bot commented Feb 16, 2026

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 665d6fe
🔍 Latest deploy log https://app.netlify.com/projects/biomejs/deploys/69938b37738fa00008bea54e
😎 Deploy Preview https://deploy-preview-3954--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Adds Playwright support to the domain documentation generator by extending DocDomains::write_description in codegen/src/domains.rs. A new RuleDomain::Playwright arm emits a dedicated header and a description stating the domain targets Playwright test projects and enforces Playwright best practices and common mistakes. Change is small (7 lines added) and follows existing domain patterns.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs(linter): add Playwright domain documentation' directly summarises the main change—adding documentation for the Playwright domain in the linter codebase.
Description check ✅ Passed The description is fully related to the changeset, explaining the purpose of adding the Playwright domain match arm, its companion PR context, and CI expectations.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Companion to biomejs/biome#8960. Adds the Playwright domain
description to the codegen match so the domains page includes it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dyc3 dyc3 force-pushed the feat/playwright-domain-docs branch from 3493bd8 to 665d6fe Compare February 16, 2026 21:25
@dyc3 dyc3 merged commit 54be939 into biomejs:main Feb 16, 2026
9 checks passed
@abossenbroek abossenbroek deleted the feat/playwright-domain-docs branch February 17, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants