Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughDocumentation updates to the VS Code and Zed extension reference guides adding a new inline Biome configuration option ( Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
src/content/docs/reference/vscode.mdx (1)
154-156: Missing Default and Scopes metadata.Other settings in this document include Default: and Scopes: information (e.g., lines 128, 138, 144). Consider adding the same metadata here for consistency.
src/content/docs/reference/zed.mdx (2)
34-50: Consider adding a default value forconfig_path.The
require_config_filesection has a> Default: \false`` callout. For consistency, it would be helpful to add similar default information here (presumably the workspace root).
136-148: Duplicate content.This section duplicates the
require_config_filedocumentation from lines 52-68. Consider removing this section or consolidating into a cross-reference.🔎 Suggested fix
-### Enable biome only when biome.json is present - -```json5 title=".zed/settings.json" -{ - "lsp": { - "biome": { - "settings": { - "require_config_file": true - } - } - } -} -``` +### Enable biome only when biome.json is present + +See the [`require_config_file`](#require_config_file) configuration option.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/content/docs/reference/vscode.mdxsrc/content/docs/reference/zed.mdx
🧰 Additional context used
🪛 LanguageTool
src/content/docs/reference/zed.mdx
[uncategorized] ~88-~88: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...to disable this rule because it's useful and you don't want to see red squiggles. In...
(COMMA_COMPOUND_SENTENCE)
src/content/docs/reference/vscode.mdx
[uncategorized] ~172-~172: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...to disable this rule because it's useful and you don't want to see red squiggles. In...
(COMMA_COMPOUND_SENTENCE)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - biomejs
- GitHub Check: Header rules - biomejs
- GitHub Check: Pages changed - biomejs
- GitHub Check: test
🔇 Additional comments (1)
src/content/docs/reference/zed.mdx (1)
70-108: Good documentation forinline_config.Clear explanation with a practical example showing how to override
biome.jsonsettings locally. The example is consistent with the VS Code documentation.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary
Part of biomejs/biome#8278