Skip to content

feat: document formatter.trailingNewline#3771

Merged
ematipico merged 2 commits intonextfrom
feat/trailing-newline
Jan 26, 2026
Merged

feat: document formatter.trailingNewline#3771
ematipico merged 2 commits intonextfrom
feat/trailing-newline

Conversation

@ematipico
Copy link
Member

Summary

Documentation for biomejs/biome#8334

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 88c7d53
🔍 Latest deploy log https://app.netlify.com/projects/biomejs/deploys/697239493f977800081265d4
😎 Deploy Preview https://deploy-preview-3771--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ematipico ematipico changed the title feat: document formatter.trailingNewline feat: document formatter.trailingNewline Jan 2, 2026
@ematipico ematipico requested review from a team January 2, 2026 10:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 2, 2026

Walkthrough

This change documents a new top-level formatter option `formatter.trailingNewline` and adds equivalent per-language options (`javascript.formatter.trailingNewline`, `json.formatter.trailingNewline`, `css.formatter.trailingNewline`, `graphql.formatter.trailingNewline`, `grit.formatter.trailingNewline`, `html.formatter.trailingNewline`) in the configuration reference. Each option describes adding a trailing newline at end-of-file, defaults to true, and includes a cautionary note against disabling it. Changes are documentation-only; no code or method signatures were modified.

Suggested reviewers

  • arendjr
  • siketyan
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: documenting the formatter.trailingNewline configuration option.
Description check ✅ Passed The description relates to the changeset by referencing the corresponding biome PR that introduced the feature being documented.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/content/docs/reference/configuration.mdx (1)

654-654: Use consistent default value format.

The default value format "> Defaults to true." differs from the established convention used throughout this document. All other defaults use the format "> Default: value" (see lines 51, 175, 182, 205, 242, etc.).

Suggested format

Change all instances from:

> Defaults to true.

To:

> Default: `true`

This makes the format consistent with the rest of the document and properly formats the boolean value as code.

Also applies to: 896-896, 1105-1105, 1251-1251, 1328-1328, 1403-1403, 1569-1569

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b31ed4 and 91c6e67.

📒 Files selected for processing (1)
  • src/content/docs/reference/configuration.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Redirect rules - biomejs
  • GitHub Check: Header rules - biomejs
  • GitHub Check: Pages changed - biomejs
  • GitHub Check: test

@ematipico ematipico merged commit f984749 into next Jan 26, 2026
8 checks passed
@ematipico ematipico deleted the feat/trailing-newline branch January 26, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants