Skip to content

fix codegen#3681

Merged
ematipico merged 2 commits intomainfrom
fix/codegefn-again
Dec 17, 2025
Merged

fix codegen#3681
ematipico merged 2 commits intomainfrom
fix/codegefn-again

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Dec 17, 2025

Summary

I'll trigger the schema job after merging this PR

@netlify
Copy link

netlify bot commented Dec 17, 2025

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit b6a7e86
🔍 Latest deploy log https://app.netlify.com/projects/biomejs/deploys/6942d818db6932000888c4f2
😎 Deploy Preview https://deploy-preview-3681--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Walkthrough

This PR updates Biome dependencies across the project to revision 86bd299ed2847614ba4c174648bc798b04639616. The primary changes include rewriting Cargo.toml to expand biome-* crate dependencies with the new revision whilst preserving per-crate features, introducing eight new top-level dependencies (anyhow, lock_api, camino, pulldown-cmark, schemars, serde, serde_json, ureq), and updating xtask_codegen. Additionally, package.json's @biomejs/wasm-web devDependency is bumped to the corresponding revision, astro.config.ts receives minor formatting adjustments to import statements, and codegen/src/lintdoc.rs updates pattern matching to destructure the Vue embedding kind's setup field.

Possibly related PRs

  • biomejs/website PR 3598: Makes coordinated edits to Cargo.toml dependency revisions and modifies codegen/src/lintdoc.rs in the same area, indicating a strong code-level connection.

Pre-merge checks and finishing touches

❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix codegen' is vague and doesn't clearly convey what the actual changes are. The PR updates dependencies, modifies pattern matching, and adjusts imports across multiple files. Consider a more descriptive title like 'Update biome dependencies and fix Vue pattern matching in codegen' that better reflects the scope of changes.
Description check ❓ Inconclusive The description mentions triggering a schema job after merge but doesn't explain what changes are being made or why they're necessary. Add details about the dependency updates and codegen fixes to help reviewers understand the purpose and impact of these changes.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/codegefn-again

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Cargo.toml (1)

64-64: Clarify the lock_api workaround or consider removing it.

lock_api isn't used directly anywhere in the codebase, suggesting it's a transitive dependency resolution fix. Either document what specific issue it resolves (so future maintainers know not to remove it), or remove it if the underlying dependency problem has been resolved with the Biome updates.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f715703 and 3240432.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml (1 hunks)
  • astro.config.ts (1 hunks)
  • codegen/src/lintdoc.rs (1 hunks)
  • package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-28T01:34:31.084Z
Learnt from: CR
Repo: biomejs/website PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-28T01:34:31.084Z
Learning: Set the BIOME_VERSION environment variable when running codegen commands (e.g., BIOME_VERSION=2.0.0 pnpm codegen all)

Applied to files:

  • Cargo.toml
🔇 Additional comments (3)
Cargo.toml (1)

18-62: Dependency revision update looks consistent.

All biome-* crates are updated to revision 86bd299ed284761... with appropriate features preserved. The uniform update across all crates is good practice.

codegen/src/lintdoc.rs (1)

1569-1569: Pattern match updated for API change.

The EmbeddingKind::Vue { setup: _ } destructuring correctly reflects the updated Vue variant structure from biome_js_syntax. This is the only location in the file requiring the update.

package.json (1)

37-37: The @biomejs/wasm-web and Cargo.toml revisions are consistent—4639616 is the short hash of commit 86bd299ed2847614ba4c174648bc798b04639616. No action needed.

Likely an incorrect or invalid review comment.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3240432 and b6a7e86.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Redirect rules - biomejs
  • GitHub Check: Header rules - biomejs
  • GitHub Check: Pages changed - biomejs
  • GitHub Check: test

@ematipico ematipico merged commit a6a995c into main Dec 17, 2025
8 of 9 checks passed
@ematipico ematipico deleted the fix/codegefn-again branch December 17, 2025 16:23
@coderabbitai coderabbitai bot mentioned this pull request Feb 3, 2026
This was referenced Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant