Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThis PR updates Biome dependencies across the project to revision Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (2 inconclusive)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Cargo.toml (1)
64-64: Clarify the lock_api workaround or consider removing it.
lock_apiisn't used directly anywhere in the codebase, suggesting it's a transitive dependency resolution fix. Either document what specific issue it resolves (so future maintainers know not to remove it), or remove it if the underlying dependency problem has been resolved with the Biome updates.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
Cargo.toml(1 hunks)astro.config.ts(1 hunks)codegen/src/lintdoc.rs(1 hunks)package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-28T01:34:31.084Z
Learnt from: CR
Repo: biomejs/website PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-28T01:34:31.084Z
Learning: Set the BIOME_VERSION environment variable when running codegen commands (e.g., BIOME_VERSION=2.0.0 pnpm codegen all)
Applied to files:
Cargo.toml
🔇 Additional comments (3)
Cargo.toml (1)
18-62: Dependency revision update looks consistent.All biome-* crates are updated to revision
86bd299ed284761...with appropriate features preserved. The uniform update across all crates is good practice.codegen/src/lintdoc.rs (1)
1569-1569: Pattern match updated for API change.The
EmbeddingKind::Vue { setup: _ }destructuring correctly reflects the updated Vue variant structure from biome_js_syntax. This is the only location in the file requiring the update.package.json (1)
37-37: The@biomejs/wasm-weband Cargo.toml revisions are consistent—4639616is the short hash of commit86bd299ed2847614ba4c174648bc798b04639616. No action needed.Likely an incorrect or invalid review comment.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - biomejs
- GitHub Check: Header rules - biomejs
- GitHub Check: Pages changed - biomejs
- GitHub Check: test
Summary
I'll trigger the schema job after merging this PR