Skip to content

feat: Add Turborepo domain#3675

Merged
ematipico merged 1 commit intobiomejs:mainfrom
anthonyshew:shew/6c4c0
Dec 16, 2025
Merged

feat: Add Turborepo domain#3675
ematipico merged 1 commit intobiomejs:mainfrom
anthonyshew:shew/6c4c0

Conversation

@anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Dec 16, 2025

Summary

Added the domain for biomejs/biome#8426 to the documentation.

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 4c937ea
🔍 Latest deploy log https://app.netlify.com/projects/biomejs/deploys/69416a6fe4d7f80008f891f3
😎 Deploy Preview https://deploy-preview-3675--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en src/content/docs/linter/domains.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Walkthrough

This change adds Turborepo domain support to the linter documentation system. The Rust codebase was updated to handle a new RuleDomain::Turborepo case in the documentation writer, emitting a dedicated section for Turborepo-specific rules. Simultaneously, the documentation content was expanded with a new Turborepo section detailing activation modes (recommended, all, none), dependencies (turbo >=1.0.0), and associated rules like noUndeclaredEnvVars. No modifications to existing domain handling or rule logic were made.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request description is essentially empty, containing only a template placeholder with no actual content describing the changes or motivation. Please fill in the description with details about why this Turborepo domain addition is needed and what problems it solves for users.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: Add Turborepo domain' clearly and specifically summarises the main change: adding support for a new Turborepo domain to the linter.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb3b943 and 4c937ea.

📒 Files selected for processing (2)
  • codegen/src/domains.rs (1 hunks)
  • src/content/docs/linter/domains.mdx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - biomejs
  • GitHub Check: Header rules - biomejs
  • GitHub Check: Pages changed - biomejs
🔇 Additional comments (2)
src/content/docs/linter/domains.mdx (1)

311-350: LGTM! Auto-generated content is consistent.

The generated Turborepo documentation follows the correct structure and matches the code changes in domains.rs. The activation examples, dependency declaration (turbo >= 1.0.0), and rule listing are all properly formatted.

codegen/src/domains.rs (1)

119-125: The RuleDomain::Turborepo implementation follows the established pattern and is properly integrated.

The domain variant exists in biome_analyze, is imported correctly, and uses the standard manifest_dependencies() method consistent with other domains (React, Vue, Qwik, etc.). The generated documentation will automatically display configured dependencies once rules are tagged with this domain.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dyc3
Copy link
Contributor

dyc3 commented Dec 16, 2025

Don't worry about the CI failures here, I think they were already here in main.

@ematipico ematipico merged commit 8f3e522 into biomejs:main Dec 16, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants