Skip to content

fix: resolve parse errors in ruledoc code blocks #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arendjr merged 1 commit into from
Sep 20, 2025
Merged

fix: resolve parse errors in ruledoc code blocks #3130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions codegen/src/lintdoc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,8 +1526,6 @@ fn print_diagnostics_or_actions(
return Ok(());
}

let mut rule_has_code_action = false;

match test.document_file_source() {
DocumentFileSource::Js(file_source) => {
// Temporary support for astro, svelte and vue code blocks
Expand Down Expand Up @@ -1575,7 +1573,6 @@ fn print_diagnostics_or_actions(
if let Some(mut diag) = signal.diagnostic() {
for action in signal.actions() {
if !action.is_suppression() {
rule_has_code_action = true;
diag = diag.add_code_suggestion(action.into());
}
}
Expand Down Expand Up @@ -1635,7 +1632,6 @@ fn print_diagnostics_or_actions(
if let Some(mut diag) = signal.diagnostic() {
for action in signal.actions() {
if !action.is_suppression() {
rule_has_code_action = true;
diag = diag.add_code_suggestion(action.into());
}
}
Expand Down Expand Up @@ -1669,7 +1665,10 @@ fn print_diagnostics_or_actions(
}
}
DocumentFileSource::Css(..) => {
let parse = biome_css_parser::parse_css(code, CssParserOptions::default());
let parse_options = CssParserOptions::default()
.allow_css_modules()
.allow_tailwind_directives();
let parse = biome_css_parser::parse_css(code, parse_options);

if parse.has_errors() {
for diag in parse.into_diagnostics() {
Expand All @@ -1695,7 +1694,6 @@ fn print_diagnostics_or_actions(
if let Some(mut diag) = signal.diagnostic() {
for action in signal.actions() {
if !action.is_suppression() {
rule_has_code_action = true;
diag = diag.add_code_suggestion(action.into());
}
}
Expand Down Expand Up @@ -1755,7 +1753,6 @@ fn print_diagnostics_or_actions(
if let Some(mut diag) = signal.diagnostic() {
for action in signal.actions() {
if !action.is_suppression() {
rule_has_code_action = true;
diag = diag.add_code_suggestion(action.into());
}
}
Expand Down
Loading