Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): use Starlight #985

Merged
merged 11 commits into from
Dec 5, 2023

Conversation

victor-teles
Copy link
Contributor

@victor-teles victor-teles commented Dec 1, 2023

Summary

This PR is part of #881 and focus on migrate the Playground page to Starlight including reuse its color scheme.
Additionally, it includes some cleanup of old files from Rome website.

Test Plan

I've done manually:

  • Responsive test
  • Accessibility test
  • Test playground's core features

@github-actions github-actions bot added the A-Website Area: website label Dec 1, 2023
Copy link
Contributor

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, overall LGTM!

website/src/pages/playground.astro Outdated Show resolved Hide resolved
website/src/layouts/StarlightSplashLayout.astro Outdated Show resolved Hide resolved
@SuperchupuDev SuperchupuDev changed the title feat(playground): use Startlight feat(playground): use Starlight Dec 1, 2023
Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for rad-torte-839a59 ready!

Name Link
🔨 Latest commit f323e15
🔍 Latest deploy log https://app.netlify.com/sites/rad-torte-839a59/deploys/656e5822cc376d00083c7ddc
😎 Deploy Preview https://deploy-preview-985--rad-torte-839a59.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@victor-teles victor-teles marked this pull request as ready for review December 4, 2023 00:22
Copy link
Contributor

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing, great work!

Two super small styling nits:

  • We could change the accent-color for the checkboxes to match the link colors, which I believe are prettier.

    We just need to add this in one of the playground .scss files:

     input[type=checkbox] {
     	accent-color: var(--sl-color-text-accent);
     }

    Here's how it looks like in dark and light mode:
    image
    image

  • I can still see a scrollbar in the page, perhaps we can overflow: hidden the page's body to avoid this since we don't really lose any space from what I tested in mobile and desktop. Perhaps we can fix it without forcing overflow: hidden even!

@ematipico
Copy link
Member

This is such a significant improvement! One thing: we should remove the dropdown for selecting the language because we don't plan to translate the playground, and choosing another language will cause a 404.

@yanthomasdev
Copy link
Contributor

we should remove the dropdown for selecting the language

I'll be working on it as a separate PR we can merge before/after this one, will also do some extra work to ensure we avoid 404s in these pages if you're coming from another language.

Copy link
Contributor

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@SuperchupuDev
Copy link
Member

SuperchupuDev commented Dec 4, 2023

Selecting an option shows some weird contrast in dark mode (it also happens inside the current playground)

image

@victor-teles victor-teles self-assigned this Dec 4, 2023
@victor-teles
Copy link
Contributor Author

victor-teles commented Dec 4, 2023

@SuperchupuDev Thank you for testing it on windows/linux, can you see if it's ok now?

@victor-teles victor-teles removed their assignment Dec 4, 2023
@SuperchupuDev
Copy link
Member

works now, thanks for fixing! there is a small white bar at the bottom now though
image

@ematipico
Copy link
Member

works now, thanks for fixing! there is a small white bar at the bottom now though image

Is that MS Edge browser?

@ematipico
Copy link
Member

With firefox it seems good

@SuperchupuDev
Copy link
Member

@ematipico i'm using chrome beta

@victor-teles
Copy link
Contributor Author

@SuperchupuDev I couldn't reproduce it using browserling.com (Windows 11 and latest Chrome version).
If you think it's a very annoying problem, Let's work on this in another PR

@yanthomasdev
Copy link
Contributor

works now, thanks for fixing! there is a small white bar at the bottom now though

I also could not reproduce this one in Chrome 120, it might be a regression in Chrome's beta.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge once @SuperchupuDev is happy

@SuperchupuDev
Copy link
Member

it's okay, it's just a very small detail, i don't think it matters that much. it looks really good regardless

@victor-teles victor-teles merged commit 1e999b5 into biomejs:main Dec 5, 2023
7 checks passed
@victor-teles victor-teles deleted the refactor/playground branch December 5, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants